Skip to content

Bump async, http, and vm_service_client packages #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leafpetersen merged 1 commit into from
Jan 19, 2018
Merged

Bump async, http, and vm_service_client packages #14136

leafpetersen merged 1 commit into from
Jan 19, 2018

Conversation

@srawlins
Copy link
Contributor

@srawlins srawlins commented Jan 17, 2018

The thrust of this PR is bumping async from 1.13.3 to >= 2.0.2.

async 2.0.2 introduces a fix for upcoming Dart 2.0 features, namely a new method on Timer.

However, to make the constraint solver happy, I first had to bump:

  • http from 0.11.3+14 to 0.11.3+16. Support for async 2.0.2 was declared in http 0.11.3+15. http 0.11.3+16 drops the dependency on stack_trace, which can be seen in dev/tools/pubspec.yaml.
  • vm_service_client from 0.2.3 to 0.2.4. Support for async 2.0.2 was declared in vm_service_client 0.2.4.

After manually bumping the versions of http and vm_service_client, I ran ./bin/flutter update-packages --force-upgrade, which successfully bumped async to 2.0.3, and resulted in this PR.

@srawlins
Copy link
Contributor Author

srawlins commented Jan 17, 2018

CC @lrhn @keertip @leafpetersen

@Hixie
Copy link
Contributor

Hixie commented Jan 17, 2018

After manually bumping the versions of http and vm_service_client

I'm concerned about the need for this. In theory, the script ignores all the versions you set and just calls pub upgrade on a dummy pubspec.yaml that includes all the packages, set to any. Can you elaborate on the steps you took to build this?

@leafpetersen
Copy link
Contributor

leafpetersen commented Jan 17, 2018

I've definitely seen non-hermetic behavior with --force-upgrade. My general approach was to do a git clean -xff between each upgrade attempt, and even with that I ended up having to start in a clean client once.

I also don't quite understand what is meant by manually bumping though.

@srawlins There's a fairly easy hack to get a global pubspec.yaml that you can use pubviz on if you're having trouble debugging dependencies.

@srawlins
Copy link
Contributor Author

srawlins commented Jan 17, 2018

Sorry, I thought my procedure was the standard one. In a clean git branch, if I run ./bin/flutter update-packages --force-upgrade, I see that vm_service_client is bumped from 0.2.3 to 0.2.4 (and device_info and url_launcher also bump). But http (and thus async) do not bump.

My procedure for "bumping" these was to find all of the non-transitive spots where these packages are depended on (git grep 'http:' |grep -v TRANSITIVE |grep pubspec), then manually edit each of those files to "bump" the version of http and vm_service_client to the version I wanted. I then ran the update-packages script, which updated async (it only comes transitively).

@srawlins
Copy link
Contributor Author

srawlins commented Jan 17, 2018

Could that test failure be a flake? Passes for me locally.

@Hixie
Copy link
Contributor

Hixie commented Jan 18, 2018

But http (and thus async) do not bump.

That sounds like a bug. The script is supposed to be idempotent; running it should get the same results regardless of the input. I don't understand how it could be affected by the input, in fact, since all it does is read the package names, make a fake pubspec.yaml, run pub get on that, then take those numbers and spam them everywhere.

If you can reproduce that, please do let me know (e.g. if there's a commit where just running the script does a different thing than editing the files then running the script). I am eager to be able to reproduce this.

@srawlins srawlins mentioned this pull request Jan 18, 2018
Closed
@Hixie
Copy link
Contributor

Hixie commented Jan 19, 2018

LGTM
Sorry, I didn't mean to suggest we shouldn't land this in the meantime. LGTM.

@leafpetersen leafpetersen merged commit 7ffcce8 into flutter:master Jan 19, 2018
@srawlins srawlins deleted the bump-async branch January 20, 2018 00:30
Hixie added a commit that referenced this pull request Jan 20, 2018
@Hixie
Revert "Bump async, http, and vm_service_client packages (#14136)"
a26d1f9 
This reverts commit 7ffcce8.
HansMuller pushed a commit that referenced this pull request Jan 20, 2018
@Hixie
[G] Revert "Exclude flutter doctor IDE validators in CI environments" (…
38ce59f 
…#14196)

* Revert "Bump async, http, and vm_service_client packages (#14136)"

This reverts commit 7ffcce8.

* Revert "Exclude flutter doctor IDE validators in CI environments (#13816)"

This reverts commit 3258c54.
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@srawlins @leafpetersen
Bump async, http, and vm_service_client packages (flutter#14136)
fda76d1
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@Hixie
[G] Revert "Exclude flutter doctor IDE validators in CI environments" (…
c52165c 
…flutter#14196)

* Revert "Bump async, http, and vm_service_client packages (flutter#14136)"

This reverts commit 7ffcce8.

* Revert "Exclude flutter doctor IDE validators in CI environments (flutter#13816)"

This reverts commit 3258c54.
This was referenced Dec 5, 2019
Closed
Closed
iskakaushik pushed a commit to iskakaushik/flutter that referenced this pull request Dec 5, 2019
Manual roll engine fdaa7cf..ee4c2a5 (8 commits)
56d50c8 
[email protected]:flutter/engine.git/compare/fdaa7cf12175...ee4c2a5

git log fdaa7cf..ee4c2a5 --first-parent --oneline
2019-12-05 [email protected] Roll src/third_party/skia 6344c2937997..0af32fdf5fea (12 commits) (flutter#14139)
2019-12-05 [email protected] Wire up Opacity on Fuchsia, round 2 (flutter#14024)
2019-12-05 [email protected] Disable fml_tests until they're fixed on Fuchsia (flutter#14137)
2019-12-05 [email protected] Started specifying the OS version for running the tests. (flutter#14094)
2019-12-04 [email protected] Roll src/third_party/skia ccca30aad770..6344c2937997 (13 commits) (flutter#14133)
2019-12-04 [email protected] Expanded our scenario_app docs. (flutter#14136)
2019-12-04 [email protected] [web][felt] fix source map path (flutter#14134)
2019-12-04 [email protected] Fix platform view offsets incorrectly taking into account device pixel ratios. (flutter#14135)
@iskakaushik iskakaushik mentioned this pull request Dec 5, 2019
Merged
This was referenced Dec 5, 2019
Closed
Merged
iskakaushik added a commit that referenced this pull request Dec 5, 2019
@iskakaushik
Manual roll engine fdaa7cf..ee4c2a5 (8 commits) (#46174)
6705d08 
[email protected]:flutter/engine.git/compare/fdaa7cf12175...ee4c2a5

git log fdaa7cf..ee4c2a5 --first-parent --oneline
2019-12-05 [email protected] Roll src/third_party/skia 6344c2937997..0af32fdf5fea (12 commits) (#14139)
2019-12-05 [email protected] Wire up Opacity on Fuchsia, round 2 (#14024)
2019-12-05 [email protected] Disable fml_tests until they're fixed on Fuchsia (#14137)
2019-12-05 [email protected] Started specifying the OS version for running the tests. (#14094)
2019-12-04 [email protected] Roll src/third_party/skia ccca30aad770..6344c2937997 (13 commits) (#14133)
2019-12-04 [email protected] Expanded our scenario_app docs. (#14136)
2019-12-04 [email protected] [web][felt] fix source map path (#14134)
2019-12-04 [email protected] Fix platform view offsets incorrectly taking into account device pixel ratios. (#14135)
engine-flutter-autoroll added a commit that referenced this pull request Dec 5, 2019
@engine-flutter-autoroll
Roll engine fdaa7cf..ee4c2a5 (8 commits) (#46178)
cb0dcbe 
[email protected]:flutter/engine.git/compare/fdaa7cf12175...ee4c2a5

git log fdaa7cf..ee4c2a5 --first-parent --oneline
2019-12-05 [email protected] Roll src/third_party/skia 6344c2937997..0af32fdf5fea (12 commits) (#14139)
2019-12-05 [email protected] Wire up Opacity on Fuchsia, round 2 (#14024)
2019-12-05 [email protected] Disable fml_tests until they're fixed on Fuchsia (#14137)
2019-12-05 [email protected] Started specifying the OS version for running the tests. (#14094)
2019-12-04 [email protected] Roll src/third_party/skia ccca30aad770..6344c2937997 (13 commits) (#14133)
2019-12-04 [email protected] Expanded our scenario_app docs. (#14136)
2019-12-04 [email protected] [web][felt] fix source map path (#14134)
2019-12-04 [email protected] Fix platform view offsets incorrectly taking into account device pixel ratios. (#14135)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srawlins @Hixie @leafpetersen @googlebot