Increase delay for checking integration_ui_keyboard_resize test success #141301
Conversation
| bool heightTextDidShrink = false; | ||
| for (int i = 0; i < 3; ++i) { | ||
| await Future<void>.delayed(const Duration(seconds: 1)); | ||
| await Future<void>.delayed(const Duration(seconds: 3)); |
There was a problem hiding this comment.
Is there an explicit signal we could wait for rather than a delay?
Bumping the delay out may work today but still leaves room for future flakes and if we can't wait for an explicit signal, it might mean our APIs are insufficient.
There was a problem hiding this comment.
Api 30 added new apis around window resizing that could possibly help.
https://medium.com/androiddevelopers/animating-your-keyboard-fb776a8fb66d
https://yatmanwong.medium.com/android-how-to-pan-the-page-up-more-25fc5c542a97
I will add that this test already does loop twice and this change modifies the step taken. If we are going to increase the time I think we should modify line 35 to 6 instead of increasing the step duration.
There was a problem hiding this comment.
Is there an explicit signal we could wait for rather than a delay?
Bumping the delay out may work today but still leaves room for future flakes and if we can't wait for an explicit signal, it might mean our APIs are insufficient.
Looks like the framework does not directly expose a way to check this; we would have to wait for the bottom inset height to change to detect this in one way or another. Looks like Android doesn't directly give a way to check for keyboard visibility either, unless I'm missing something.
Going to land this since the test is flaking pretty frequently. @johnmccutchan if you think this is worth pouring more effort into, let me know; more than happy to file an issue for finding a longer term/more fool-proof solution!
camsim99
added
the
autosubmit
flutter/flutter@9f2e681...7dc856a 2024-01-12 [email protected] Revert "Reverts "Run iOS staging tests with Xcode 15.2"" (flutter/flutter#141420) 2024-01-12 [email protected] Roll Packages from 0744fe6 to d74d687 (5 revisions) (flutter/flutter#141449) 2024-01-12 [email protected] Fix `FlexibleSpaceBar` centered title position and title color (flutter/flutter#140883) 2024-01-12 [email protected] Do not reset framework checkout before running customer tests (flutter/flutter#141013) 2024-01-12 [email protected] Increase delay for checking integration_ui_keyboard_resize test success (flutter/flutter#141301) 2024-01-12 [email protected] Add osx_sdk context for mac builds. (flutter/flutter#141422) 2024-01-12 [email protected] Roll Flutter Engine from ecdaed76f284 to 44a0a6ee4d39 (18 revisions) (flutter/flutter#141432) 2024-01-12 [email protected] Add support for Gradle Kotlin DSL (flutter/flutter#140744) 2024-01-12 [email protected] Fix typo (flutter/flutter#141426) 2024-01-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run iOS staging tests with Xcode 15.2" (flutter/flutter#141412) 2024-01-11 [email protected] Run iOS staging tests with Xcode 15.2 (flutter/flutter#141392) 2024-01-11 [email protected] Fix `ListWheelScrollView` in an `AnimatedContainer` with zero height throw an error (flutter/flutter#141372) 2024-01-11 [email protected] make asset_test.dart tests not dependent on context (flutter/flutter#141331) 2024-01-11 [email protected] Expose 'enable' property to allow the user to disable the SearchBar (flutter/flutter#137388) 2024-01-11 [email protected] Add impeller key to skia gold client, Turn on a framework test shard that will run unit tests with --enable-impeller (flutter/flutter#141341) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Increases delay for checking keyboard resizing to potentially accommodate the occasional longer delay of the Pixel 7 Pro.
Intended to address #140645.
Pre-launch Checklist
///).