It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

This code is covered by a golden test. The golden test isn't failing because it's fuzzy matching to the image from before #137275.

Shouldn't we be marking old tests as wrong once we decide we're changing the behaviour? cc @Piinks

Shouldn't we be marking old tests as wrong once we decide we're changing the behaviour? cc @Piinks

I asked @Piinks that question and the answer was that the incorrect image will expire naturally.

Asked and answered on Discord as well: https://discord.com/channels/608014603317936148/608018585025118217/1197283919796633600

Piinks — Yesterday at 2:58 PM
IIRC, It'll still detect regressions. Gold has a short memory. Once the image changes, and it stops seeing the prior image, it forgets about it. Otherwise, you could explicitly go in and mark the prior image negative. But, I think this is similar to when we used flutter/goldens, where branches out of sync could still pass if they were generating an older image, so going in and marking it negative would break alternate branches people are working on

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.