Add RadioListItem use-case to a11y_assessments #140984
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I keep forgetting that we also have tests for this package. Hold on. Adding a test. |
|
Added a test. Also noticed we didn't have a test for the check box use-case, so I added a test there too. |
yjbanov
added
the
autosubmit
flutter/flutter@ddf60fb...5dea6b9 2024-01-21 [email protected] Roll Flutter Engine from 2b31ad2fb819 to a7b207d5a1fe (1 revision) (flutter/flutter#141945) 2024-01-21 [email protected] [flutter_tools] update analyze_once_test.dart to be null-safe (flutter/flutter#141790) 2024-01-21 [email protected] Adjust the position of require File.expand_path (flutter/flutter#141521) 2024-01-21 [email protected] Add RadioListItem use-case to a11y_assessments (flutter/flutter#140984) 2024-01-20 [email protected] Roll Flutter Engine from 704ef3399012 to 2b31ad2fb819 (1 revision) (flutter/flutter#141937) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Adds a use-case screen for
RadioListTile, similar to theCheckBoxListTile. This screen can help test scenarios such as the one reported in #126805.