Skip to content

[CP] Fix tool crash while debugging an iOS device and deleting a temp directory fails #140842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jan 8, 2024
Merged

[CP] Fix tool crash while debugging an iOS device and deleting a temp directory fails #140842

auto-submit merged 1 commit into from
Jan 8, 2024

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jan 3, 2024 •
edited
Loading

Original issue: #140416
Original PR: #140415
CP request issue: #140843

@christopherfujino
[flutter_tools] handle FileSystemException trying to delete temp dire…
79058d6 
…ctory from core_devices.dart (flutter#140415)

Fixes flutter#140416, the top crasher on stable/3.16.4
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos a: desktop Running on desktop f: focus Focus traversal, gaining or losing focus f: integration_test The flutter/packages/integration_test plugin labels Jan 3, 2024
@christopherfujino christopherfujino changed the base branch from master to flutter-3.16-candidate.0 January 3, 2024 00:53
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 3, 2024

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino christopherfujino mentioned this pull request Jan 3, 2024
Closed
@christopherfujino christopherfujino changed the title [CP] fix [CP] Fix tool crash while debugging an iOS device and deleting a temp directory fails Jan 3, 2024
@christopherfujino christopherfujino marked this pull request as ready for review January 3, 2024 00:59
andrewkolos
andrewkolos approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit auto-submit bot merged commit 4ec0689 into flutter:flutter-3.16-candidate.0 Jan 8, 2024
@christopherfujino christopherfujino deleted the flutter-3.16-candidate.0-cherrypicks branch January 9, 2024 00:09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2024
@engine-flutter-autoroll
4ec0689fa [CP] Fix tool crash while debugging an iOS device and delet…
d893808 
…ing a temp directory fails (flutter/flutter#140842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
@engine-flutter-autoroll
4ec0689fa [CP] Fix tool crash while debugging an iOS device and delet…
548b1db 
…ing a temp directory fails (flutter/flutter#140842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
@engine-flutter-autoroll
4ec0689fa [CP] Fix tool crash while debugging an iOS device and delet…
c4da260 
…ing a temp directory fails (flutter/flutter#140842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: focus Focus traversal, gaining or losing focus f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christopherfujino @andrewkolos @godofredoc