Fix setup race in asset bundle tests #140832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140665 by replacing use of
setUpAllandteardownAllwithsetUpandteardownrespectively.My theory has to how this issue happened (and how this PR fixes it) is that
setUpAllis not guaranteed to run after anysetUpin any parent test groups. However,setUpis guaranteed to run after any set-up callbacks in parent groups. From the documentation:Meanwhile,
setUpAllhas a weaker documented guarantee that applies only to othersetUpAllcalls:Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.