Skip to content

Conversation

@CoderDake
Copy link
Contributor

Fixes flutter/devtools#6871

Add the width and height to the inspector overlay. 1 decimal precision is used since that matches the way Devtools displays the values.

Examples

Screenshot 2023-12-28 at 2 39 49 PM Screenshot 2023-12-28 at 2 39 42 PM Screenshot 2023-12-28 at 2 39 37 PM

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@CoderDake CoderDake requested a review from elliette December 28, 2023 20:47
@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 28, 2023
@CoderDake CoderDake marked this pull request as ready for review December 28, 2023 21:27
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #140709 at sha 2a17f89

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Dec 28, 2023
@CoderDake CoderDake added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 29, 2023
@CoderDake
Copy link
Contributor Author

CoderDake commented Dec 29, 2023

Manually pulled the golden widgets into a test app and verified that things look right. I've approved the golden change.

@auto-submit auto-submit bot merged commit 186659d into flutter:master Dec 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show height and width dimensions on on device inspector overlay

2 participants