Skip to content

[web] Re-enable text field test now that fix has landed in engine #140678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Dec 27, 2023
Merged

[web] Re-enable text field test now that fix has landed in engine #140678

auto-submit merged 1 commit into from
Dec 27, 2023

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Dec 27, 2023

Re-enables skipped flaky test now that the underlying cause of flakiness (GPU memory leak) has been fixed in the engine and the fix has rolled into the framework.

The fix is here: flutter/engine#49336

Fixes #137669

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Dec 27, 2023
kevmoo
kevmoo approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 27, 2023
@auto-submit auto-submit bot merged commit 13feba5 into flutter:master Dec 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 28, 2023
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
92ada56 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 28, 2023
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
de3ed5d 
…gine (flutter/flutter#140678)
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
@harryterkelsen @CoderDake
[web] Re-enable text field test now that fix has landed in engine (fl…
4a0d179 
…utter#140678)

Re-enables skipped flaky test now that the underlying cause of flakiness (GPU memory leak) has been fixed in the engine and the fix has rolled into the framework.

The fix is here: flutter/engine#49336

Fixes flutter#137669
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
e2b6c15 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
71a8101 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
717cd51 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
5d000d8 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 31, 2023
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
aeeff51 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
d5d0e24 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
a9c0871 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
d02f1d8 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
e433829 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
29a3032 
…gine (flutter/flutter#140678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
1ef8fde 
…gine (flutter/flutter#140678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
23ff6d2 
…gine (flutter/flutter#140678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
fd04059 
…gine (flutter/flutter#140678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
13feba5 [web] Re-enable text field test now that fix has landed in en…
77d3fe4 
…gine (flutter/flutter#140678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmoo kevmoo kevmoo approved these changes

+1 more reviewer

@htoor3 htoor3 htoor3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux web_canvaskit_tests_4 is 5.05% flaky

3 participants

@harryterkelsen @kevmoo @htoor3