Skip to content

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Dec 21, 2023

Original PR: #138057
Revert: #140502
Issue: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_test_performance/12787/overview
Exception: flutter test rendered unexpected output (1 bad lines)
Explanation: leak tracker adds tear down even when there is no leak tracking, because at the moment of adding tear down it is unclear if leak tracking will be used for some tests.
Fix: add enabling flag for leak tracker and make creation of tear down conditional.
Prerequisites:

This reverts commit 78fea14.
@polina-c polina-c marked this pull request as ready for review January 3, 2024 20:01
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit baf6ba1 into flutter:master Jan 3, 2024
@polina-c polina-c deleted the implement-4 branch January 3, 2024 20:21
@zanderso zanderso added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 3, 2024
auto-submit bot pushed a commit that referenced this pull request Jan 3, 2024
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 3, 2024
auto-submit bot added a commit that referenced this pull request Jan 3, 2024
Reverts #140521
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Original PR: #138057
Revert: #140502
Issue: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_test_performance/12787/overview
Exception: flutter test rendered unexpected output (1 bad lines)
Explanation: leak tracker adds tear down even when there is no leak tracking, because at the moment of adding tear down it is unclear if leak tracking will be used for some tests.
Fix: add enabling flag for leak tracker and make creation of tear down conditional.
Prerequisites:
@polina-c polina-c restored the implement-4 branch January 3, 2024 22:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
tarrinneal added a commit to flutter/packages that referenced this pull request Jan 5, 2024
Manual roll Flutter from 11def8e to cc40425 (118 revisions)

Manual roll requested by [email protected]

flutter/flutter@11def8e...cc40425

2024-01-05 [email protected] Roll Flutter Engine from
0bbb4d61ce82 to f60d9a9a3395 (1 revision) (flutter/flutter#140993)
2024-01-04 [email protected] Roll Flutter Engine from
b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (flutter/flutter#140990)
2024-01-04 [email protected] [web] Fix and unskip a few more CanvasKit
tests (flutter/flutter#140821)
2024-01-04 [email protected] Roll Flutter Engine from
bd175aa5e0b6 to b2a9ce88a19e (1 revision) (flutter/flutter#140986)
2024-01-04 [email protected] Pin package:vm_service
(flutter/flutter#140972)
2024-01-04 [email protected] Add scrollbar
for menus (flutter/flutter#140941)
2024-01-04 [email protected] manual pub roll to pick up dds
fixes (flutter/flutter#140979)
2024-01-04 [email protected] Roll Flutter Engine from
b81023eb71c9 to bd175aa5e0b6 (2 revisions) (flutter/flutter#140980)
2024-01-04 [email protected] Temporarily remove env variable for leak
tracking bots. (flutter/flutter#140978)
2024-01-04 [email protected] Add Flutter CI status to README
(flutter/flutter#140513)
2024-01-04 [email protected] Reland "integrate testWidgets with leak
tracking" (#140521) (flutter/flutter#140928)
2024-01-04 [email protected] Run half of iOS
devicelab tests with Xcode 15 (flutter/flutter#140927)
2024-01-04 [email protected] Fix
`SegmentedButton` states update logic (flutter/flutter#140772)
2024-01-04 [email protected] Roll Flutter Engine from
f539acfb8c5a to b81023eb71c9 (1 revision) (flutter/flutter#140973)
2024-01-04 [email protected] [Fix] Consistency in
ButtonStyleButton related Tests (flutter/flutter#140610)
2024-01-04 [email protected] Roll Packages from
bbb4134 to 31fc7b5 (6 revisions) (flutter/flutter#140967)
2024-01-04 [email protected] Fix local engine use in macOS plugins
(flutter/flutter#140222)
2024-01-04 [email protected] Roll Flutter Engine from
7d5a120a601b to f539acfb8c5a (2 revisions) (flutter/flutter#140959)
2024-01-04 [email protected] Roll Flutter Engine from
1ff3cb885842 to 7d5a120a601b (1 revision) (flutter/flutter#140946)
2024-01-04 [email protected] Roll Flutter Engine from
c8bf51f0d4cd to 1ff3cb885842 (1 revision) (flutter/flutter#140943)
2024-01-04 [email protected] Roll Flutter Engine from
bfd2d8a100ec to c8bf51f0d4cd (2 revisions) (flutter/flutter#140939)
2024-01-04 [email protected] Roll Flutter Engine from
28ae9e35c331 to bfd2d8a100ec (1 revision) (flutter/flutter#140937)
2024-01-04 [email protected] Roll Flutter Engine from
ab4098c742f8 to 28ae9e35c331 (1 revision) (flutter/flutter#140936)
2024-01-04 [email protected] Roll Flutter Engine from
e169f3677008 to ab4098c742f8 (2 revisions) (flutter/flutter#140933)
2024-01-03 [email protected] Roll Flutter Engine from
7c2adb811059 to e169f3677008 (1 revision) (flutter/flutter#140929)
2024-01-03 [email protected] Remove deprecated bitcode stripping from
tooling (flutter/flutter#140903)
2024-01-03 [email protected] Add Windows leak
tracking targets (flutter/flutter#140423)
2024-01-03 [email protected] [github actions] refactor and fix
cherry pick actions (flutter/flutter#140499)
2024-01-03 [email protected] Migrate Xcode projects last version checks
to Xcode 15.1 (flutter/flutter#140256)
2024-01-03 [email protected] Roll Flutter Engine from
bf232c4da241 to 7c2adb811059 (3 revisions) (flutter/flutter#140920)
2024-01-03 [email protected] fix typo and reflow
(flutter/flutter#140925)
2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Re-land integrate testWidgets with leak tracking."
(flutter/flutter#140926)
2024-01-03 [email protected] Roll Flutter Engine from
bf979d220283 to bf232c4da241 (1 revision) (flutter/flutter#140915)
2024-01-03 [email protected] Changes the regular cursor to a
floating cursor when a long press occurs. (flutter/flutter#138479)
2024-01-03 [email protected] Add
`SegmentedButton.styleFrom` (flutter/flutter#137542)
2024-01-03 [email protected] Roll Flutter Engine from
c62bcff5b809 to bf979d220283 (1 revision) (flutter/flutter#140910)
2024-01-03 [email protected] Re-land integrate testWidgets with leak
tracking. (flutter/flutter#140521)
2024-01-03 [email protected] Roll Flutter Engine from
98b72c7ffe71 to c62bcff5b809 (2 revisions) (flutter/flutter#140905)
2024-01-03 [email protected] [flutter_tools] add support for
--enable-impeller to test device. (flutter/flutter#140899)
2024-01-03 [email protected] Roll Flutter Engine from
cf7536964a2f to 98b72c7ffe71 (1 revision) (flutter/flutter#140897)
2024-01-03 [email protected] Handle
KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutter#140808)
2024-01-03 [email protected] Add Lucas Saudon to AUTHORS
(flutter/flutter#139965)
2024-01-03 [email protected] Link to wiki page
about updating dependencies in each `pubspec.yaml` file
(flutter/flutter#140826)
2024-01-03 [email protected] Marks Linux_pixel_7pro
native_assets_android to be unflaky (flutter/flutter#140866)
...

---------

Co-authored-by: Tarrin Neal <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants