Skip to content

Reverts "[web] Re-enable test now that source of flakiness is fixed" #140515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Dec 21, 2023
Merged

Reverts "[web] Re-enable test now that source of flakiness is fixed" #140515

auto-submit merged 1 commit into from
Dec 21, 2023

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Dec 21, 2023 •
edited by cbracken
Loading

Reverts #140462
Initiated by: cbracken
This change reverts the following previous change:
Original Description:
The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214

Fixes #137669
Fixes #140514

As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Dec 21, 2023
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Dec 21, 2023
@auto-submit auto-submit bot merged commit cb50d4a into master Dec 21, 2023
@auto-submit auto-submit bot deleted the revert_11bfb3c46a7be05eb87b058d6e0ef565ecb6c81f branch December 21, 2023 17:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
4321a90 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
5ee4fa2 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
99e23a0 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
a61c5e9 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
f2ac74e 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
907535a 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
81e6c5d 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
22ceba7 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
45f1913 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 27, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
f001327 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
03f42dc 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
dd9bef1 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
66f62e3 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 31, 2023
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
dbfa22a 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
30b892c 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
67bf04c 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
f0fa0ff 
… fixed" (flutter/flutter#140515)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
6f09161 
… fixed" (flutter/flutter#140515)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
1288467 
… fixed" (flutter/flutter#140515)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
9eae14a 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
0a4d1ea 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
da720ac 
… fixed" (flutter/flutter#140515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
318c45c 
… fixed" (flutter/flutter#140515)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
965a00e 
… fixed" (flutter/flutter#140515)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
cb50d4a Reverts "[web] Re-enable test now that source of flakiness is…
05616d7 
… fixed" (flutter/flutter#140515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@cbracken cbracken

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux web_canvaskit_tests_6 is Flaky Linux web_canvaskit_tests_4 is 5.05% flaky

2 participants

@fluttergithubbot @cbracken