Skip to content

Conversation

@godofredoc
Copy link
Contributor

Updates to use contents: write and pull-requests: write.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Updates to use contents: write and pull-requests: write
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

sorry for the delay was busy with some other stuff. I thought the line at L10 permissions: write-all would already cover both contents and pull-requests permissions but maybe I was wrong.

Another thing I was trying to figure out was that, when using my personal PAT token, I don't need to add any permission statements and the workflow would succeed (https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7281157041)
would the bot account lack some permissions that human have?

And the actions bot PAT token seems to have all the permissions on workflows and actions

images (1)

@godofredoc godofredoc merged commit cf3760b into master Dec 20, 2023
@godofredoc godofredoc deleted the godofredoc-patch-2 branch December 20, 2023 22:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 21, 2023
flutter/flutter@da0cd69...11def8e

2023-12-21 [email protected] Update README.md (flutter/flutter#140382)
2023-12-21 [email protected] Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502)
2023-12-21 [email protected] Integrate testWidgets with leak tracking. (flutter/flutter#138057)
2023-12-21 [email protected] Fix import pattern (flutter/flutter#140425)
2023-12-20 [email protected] Update job permissions (flutter/flutter#140476)
2023-12-20 [email protected] Roll pub packages (flutter/flutter#140472)
2023-12-20 [email protected] Remove outdated ignores from tool (flutter/flutter#140467)
2023-12-20 [email protected] Remove outdated ignores from framework (flutter/flutter#140465)
2023-12-20 [email protected] Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469)
2023-12-20 [email protected] Part 1/n migration steps for kotlin migration (flutter/flutter#140452)
2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468)
2023-12-20 [email protected] [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462)
2023-12-20 [email protected] Eliminate Cirrus build status badge (flutter/flutter#140461)
2023-12-20 [email protected] Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438)
2023-12-20 [email protected] Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450)
2023-12-20 [email protected] _TabBarViewState should not recreate page controller (flutter/flutter#135500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
Updates to use contents: write and pull-requests: write.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants