Skip to content

Enable android_preview_tool_integration_tests check #140470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Dec 21, 2023
Merged

Enable android_preview_tool_integration_tests check #140470

auto-submit merged 2 commits into from
Dec 21, 2023

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Dec 20, 2023 •
edited
Loading

Enables the check that was added in #131901.

Has been passing since #140099 (30 runs). Not sure what the normal number of successful runs we wait for is before enabling, let me know if we should wait for more data.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall requested review from a team and christopherfujino December 20, 2023 20:24
christopherfujino
christopherfujino approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2023
@auto-submit auto-submit bot merged commit a3e0fa5 into flutter:master Dec 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
427e1a3 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
1e98897 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
14062d3 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
f8dcfe7 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
9740a20 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
69818a2 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
0c95d0e 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
ffd0bbd 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
312781f 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 27, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
15f51cb 
…r/flutter#140470)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
2563530 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
57f45c2 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
726c30a 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
5918541 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 31, 2023
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
dfa0873 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
ab1b79c 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
3c17902 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
d656ae3 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
71610be 
…r/flutter#140470)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
a8e6187 
…r/flutter#140470)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
f888515 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
9045722 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
647a19b 
…r/flutter#140470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
a059749 
…r/flutter#140470)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
29ba372 
…r/flutter#140470)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
a3e0fa5 Enable android_preview_tool_integration_tests check (flutte…
b5b5871 
…r/flutter#140470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmackall @reidbaker @christopherfujino