Skip to content

Conversation

@LongCatIsLooong
Copy link
Contributor

Extracted from #139717 as-is. Landing this change first so we can avoid doing a g3fix.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Dec 20, 2023
@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2023
@auto-submit auto-submit bot merged commit e2e8bcb into flutter:master Dec 20, 2023
@LongCatIsLooong LongCatIsLooong deleted the reland-text-range-finder branch December 20, 2023 22:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 21, 2023
flutter/flutter@da0cd69...11def8e

2023-12-21 [email protected] Update README.md (flutter/flutter#140382)
2023-12-21 [email protected] Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502)
2023-12-21 [email protected] Integrate testWidgets with leak tracking. (flutter/flutter#138057)
2023-12-21 [email protected] Fix import pattern (flutter/flutter#140425)
2023-12-20 [email protected] Update job permissions (flutter/flutter#140476)
2023-12-20 [email protected] Roll pub packages (flutter/flutter#140472)
2023-12-20 [email protected] Remove outdated ignores from tool (flutter/flutter#140467)
2023-12-20 [email protected] Remove outdated ignores from framework (flutter/flutter#140465)
2023-12-20 [email protected] Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469)
2023-12-20 [email protected] Part 1/n migration steps for kotlin migration (flutter/flutter#140452)
2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468)
2023-12-20 [email protected] [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462)
2023-12-20 [email protected] Eliminate Cirrus build status badge (flutter/flutter#140461)
2023-12-20 [email protected] Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438)
2023-12-20 [email protected] Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450)
2023-12-20 [email protected] _TabBarViewState should not recreate page controller (flutter/flutter#135500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
Extracted from flutter#139717 as-is. Landing this change first so we can avoid doing a g3fix.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants