Part 1/n migration steps for kotlin migration #140452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
tool
bartekpacia
approved these changes
Dec 20, 2023
Contributor
|
test-exempt: cleanup |
Contributor
Author
That is the next pr, Trying to keep them small. |
gmackall
approved these changes
Dec 20, 2023
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
LGTM outside of some spacing questions
christopherfujino
approved these changes
Dec 20, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM with nit about the indentation
reidbaker
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/140452, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
reidbaker
added
the
autosubmit
XilaiZhang
added
cp: beta
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 21, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 21, 2023
flutter/flutter@da0cd69...11def8e 2023-12-21 [email protected] Update README.md (flutter/flutter#140382) 2023-12-21 [email protected] Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502) 2023-12-21 [email protected] Integrate testWidgets with leak tracking. (flutter/flutter#138057) 2023-12-21 [email protected] Fix import pattern (flutter/flutter#140425) 2023-12-20 [email protected] Update job permissions (flutter/flutter#140476) 2023-12-20 [email protected] Roll pub packages (flutter/flutter#140472) 2023-12-20 [email protected] Remove outdated ignores from tool (flutter/flutter#140467) 2023-12-20 [email protected] Remove outdated ignores from framework (flutter/flutter#140465) 2023-12-20 [email protected] Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469) 2023-12-20 [email protected] Part 1/n migration steps for kotlin migration (flutter/flutter#140452) 2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468) 2023-12-20 [email protected] [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462) 2023-12-20 [email protected] Eliminate Cirrus build status badge (flutter/flutter#140461) 2023-12-20 [email protected] Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438) 2023-12-20 [email protected] Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450) 2023-12-20 [email protected] _TabBarViewState should not recreate page controller (flutter/flutter#135500) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
Following https://developer.android.com/build/migrate-to-kotlin-dsl 1/n Add parentheses to method calls Should be a no-op change. If you see a behavioral change please flag it.
Merged
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
…in DSL in the future (#142146) This PR will make it easier for future Flutter-Android apps/plugins/modules etc. to migrate to Gradle Kotlin DSL. This PR is similar to #140452 but concerns public Gradle templates instead of Flutter's internal Gradle code. It should be a no-op change. **before**  **after** 
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://developer.android.com/build/migrate-to-kotlin-dsl
1/n Add parentheses to method calls
Should be a no-op change. If you see a behavioral change please flag it.
Pre-launch Checklist
///).