Skip to content

Fix flavor conditional asset bundling for macos #140433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 6 commits into from
Dec 21, 2023
Merged

Fix flavor conditional asset bundling for macos #140433

auto-submit merged 6 commits into from
Dec 21, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Dec 20, 2023 •
edited
Loading

Fixes #140430
Fixes #140432 while we are at it

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 20, 2023
@andrewkolos
Copy link
Contributor Author

andrewkolos commented Dec 20, 2023 •
edited
Loading

I ran the affected devicelab tests in the try pool. Everything passed:

@andrewkolos andrewkolos marked this pull request as ready for review December 20, 2023 19:27
christopherfujino
christopherfujino reviewed Dec 20, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Dec 20, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Dec 20, 2023
View reviewed changes
christopherfujino
christopherfujino approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2023
@auto-submit auto-submit bot merged commit 9e104eb into flutter:master Dec 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
90e3e7b 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
6586746 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
a9f18dd 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
1fd2479 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
d14dee8 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
bc95ff4 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
9f95476 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
ca736f4 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 30, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
2e926b6 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 31, 2023
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
7490e57 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
96311df 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
5af692f 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
816bdd1 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
7eddd25 
…ter#140433)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
1b038b9 
…ter#140433)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
68ef1fe 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
9a853a7 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
fe73bb9 
…ter#140433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 4, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
67a394e 
…ter#140433)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
1ed465b 
…ter#140433)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
9e104eb Fix flavor conditional asset bundling for macos (flutter/flut…
5fd388e 
…ter#140433)
@andrewkolos andrewkolos deleted the fix-flavor-conditional-asset-bundling-for-macos branch April 29, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

2 participants

@andrewkolos @christopherfujino