Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Dec 19, 2023

Fixes #140416, the top crasher on stable/3.16.4

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 19, 2023
});

testWithoutContext('bypasses error handling when withAllowedFailure is used', () {
testWithoutContext('bypasses error handling when noExitOnFailure is used', () {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are just to make this test less confusing (and more precise)

Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 19, 2023

auto label is removed for flutter/flutter/140415, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 19, 2023

auto label is removed for flutter/flutter/140415, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2023
@auto-submit auto-submit bot merged commit ef1227f into flutter:master Dec 20, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 20, 2023
flutter/flutter@0eb7881...da0cd69

2023-12-20 [email protected] Revert automated changes made to deprecated settings.gradle (plugins.each)  (flutter/flutter#140037)
2023-12-20 [email protected] [github actions] change minimal example workflow to be manually dispatched (flutter/flutter#140435)
2023-12-20 [email protected] Make `TextSpan` hit testing precise. (flutter/flutter#139717)
2023-12-20 [email protected] [github actions] add minimal workflow to test token (flutter/flutter#140363)
2023-12-20 [email protected] Roll Flutter Engine from 5279873a8635 to c70f0a495ace (2 revisions) (flutter/flutter#140431)
2023-12-20 [email protected] Roll Flutter Engine from df1593e96a6b to 5279873a8635 (2 revisions) (flutter/flutter#140428)
2023-12-20 [email protected] [flutter_tools] handle FileSystemException trying to delete temp directory from core_devices.dart (flutter/flutter#140415)
2023-12-19 [email protected] Move hybrid_android_views_integration_test back to Moto G4 (flutter/flutter#140421)
2023-12-19 [email protected] Roll Flutter Engine from 3b156c8ce9bd to df1593e96a6b (2 revisions) (flutter/flutter#140422)
2023-12-19 [email protected] Added onEnd callback into AnimatedSize (flutter/flutter#139859)
2023-12-19 [email protected] Roll Flutter Engine from 3f45f9db4471 to 3b156c8ce9bd (1 revision) (flutter/flutter#140413)
2023-12-19 [email protected] Roll Flutter Engine from 187334c39b44 to 3f45f9db4471 (3 revisions) (flutter/flutter#140412)
2023-12-19 [email protected] Remove workarounds for `plugin_lint_mac` needed for older version of Cocoapods (flutter/flutter#140395)
2023-12-19 [email protected] Roll Flutter Engine from b87a782ce3a3 to 187334c39b44 (2 revisions) (flutter/flutter#140398)
2023-12-19 [email protected] Roll Flutter Engine from 1d5a141917fa to b87a782ce3a3 (1 revision) (flutter/flutter#140390)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
…ctory from core_devices.dart (flutter#140415)

Fixes flutter#140416, the top crasher on stable/3.16.4
@christopherfujino christopherfujino deleted the handle-file-system-exception-from-core-devices branch January 3, 2024 00:51
christopherfujino added a commit to chris-forks/flutter that referenced this pull request Jan 3, 2024
…ctory from core_devices.dart (flutter#140415)

Fixes flutter#140416, the top crasher on stable/3.16.4
auto-submit bot pushed a commit that referenced this pull request Jan 8, 2024
… directory fails (#140842)

Original issue: #140416
Original PR: #140415
CP request issue: #140843
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_tools] PathNotFoundException deleting temp dir in IOSCoreDeviceControl._listCoreDevices

2 participants