Fix spell check throws when text contains regex reserved characters #140384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
camsim99
approved these changes
Dec 26, 2023
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
LGTM, just left a request for testing the spell check output in the test :)
Contributor
There was a problem hiding this comment.
Can we also test the output of this?
bleroux
force-pushed
the
fix_spellcheck_throws_when_text_contains_regex_reserved_character
branch
from
5db469a to
220ca65
Compare
bleroux
force-pushed
the
fix_spellcheck_throws_when_text_contains_regex_reserved_character
branch
from
220ca65 to
b50bf98
Compare
bleroux
deleted the
fix_spellcheck_throws_when_text_contains_regex_reserved_character
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 9, 2024
Roll Flutter from c6ddb73 to 126302d (32 revisions) flutter/flutter@c6ddb73...126302d 2024-01-09 [email protected] Roll Flutter Engine from 820645dbcc69 to b3c8597df0e2 (5 revisions) (flutter/flutter#141175) 2024-01-09 [email protected] Roll Packages from 5aef49b to 09205ca (2 revisions) (flutter/flutter#141173) 2024-01-09 [email protected] [Android] Add custom system-wide text selection toolbar buttons for SelectableRegion (flutter/flutter#141103) 2024-01-09 [email protected] Update Chips and `ChipTheme` tests and for Material 3 (flutter/flutter#141022) 2024-01-09 [email protected] Update `chip_test.dart` tests for Material 3 (flutter/flutter#140964) 2024-01-09 [email protected] Fix spell check throws when text contains regex reserved characters (flutter/flutter#140384) 2024-01-09 [email protected] Native assets support for Android Add2app (flutter/flutter#140802) 2024-01-09 [email protected] Roll Flutter Engine from d13479968b8f to 820645dbcc69 (3 revisions) (flutter/flutter#141152) 2024-01-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.22.11 to 3.23.0 (flutter/flutter#141132) 2024-01-09 [email protected] Shift mac Pixel 7 Pro tests to prod (flutter/flutter#141142) 2024-01-09 [email protected] Roll Flutter Engine from 3f0f8913169e to d13479968b8f (2 revisions) (flutter/flutter#141147) 2024-01-09 [email protected] Roll Flutter Engine from 09a74a08c819 to 3f0f8913169e (2 revisions) (flutter/flutter#141146) 2024-01-09 [email protected] Roll Flutter Engine from ee1ded6d1c44 to 09a74a08c819 (3 revisions) (flutter/flutter#141144) 2024-01-08 [email protected] [docs] Add document content related to chip shape (flutter/flutter#140015) 2024-01-08 [email protected] Roll Flutter Engine from 00ff33274fc0 to ee1ded6d1c44 (2 revisions) (flutter/flutter#141133) 2024-01-08 [email protected] Roll Flutter Engine from 70c45157c60a to 00ff33274fc0 (2 revisions) (flutter/flutter#141128) 2024-01-08 [email protected] Roll Flutter Engine from b57c899aefd7 to 70c45157c60a (1 revision) (flutter/flutter#141125) 2024-01-08 [email protected] Roll Flutter Engine from db564ffb3549 to b57c899aefd7 (1 revision) (flutter/flutter#141114) 2024-01-08 [email protected] Roll Packages from b9b6d38 to 5aef49b (2 revisions) (flutter/flutter#141117) 2024-01-08 [email protected] Roll Flutter Engine from bbebee146508 to db564ffb3549 (5 revisions) (flutter/flutter#141112) 2024-01-08 [email protected] Disable test shuffling in widget_tester_leaks_test.dart (flutter/flutter#141110) 2024-01-08 [email protected] Roll Flutter Engine from 702ae19c0026 to bbebee146508 (1 revision) (flutter/flutter#141088) 2024-01-08 [email protected] Roll Flutter Engine from 5e1d18bb51d1 to 702ae19c0026 (1 revision) (flutter/flutter#141084) 2024-01-07 [email protected] Roll Flutter Engine from 845ffd16d228 to 5e1d18bb51d1 (1 revision) (flutter/flutter#141076) 2024-01-07 [email protected] Roll Flutter Engine from ffc84af47827 to 845ffd16d228 (1 revision) (flutter/flutter#141075) 2024-01-07 [email protected] Roll Flutter Engine from cc9362752996 to ffc84af47827 (2 revisions) (flutter/flutter#141074) 2024-01-06 [email protected] Roll Flutter Engine from a5173fe3a912 to cc9362752996 (1 revision) (flutter/flutter#141066) 2024-01-06 [email protected] Roll Flutter Engine from 1dfcb6967dd1 to a5173fe3a912 (1 revision) (flutter/flutter#141063) 2024-01-06 [email protected] Roll Flutter Engine from 2fd75c06e0bd to 1dfcb6967dd1 (1 revision) (flutter/flutter#141062) 2024-01-06 [email protected] Roll Flutter Engine from 7f872b265733 to 2fd75c06e0bd (1 revision) (flutter/flutter#141059) 2024-01-06 [email protected] Roll Flutter Engine from 8d1789a43319 to 7f872b265733 (1 revision) (flutter/flutter#141056) 2024-01-06 [email protected] Roll Flutter Engine from fcb40168f159 to 8d1789a43319 (1 revision) (flutter/flutter#141053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue related to the spell check implementation usage of Regex (searched text should be escaped).
Related Issue
Fixes #136032.
Tests
Adds 1 test.