Skip to content

Conversation

@sbatezat
Copy link

Add the ability to set route settings on PopupMenuButton

Fix #140372

…utton

Add the ability to set route settings on PopupMenuButton
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Dec 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 19, 2023
@goderbauer
Copy link
Member

Looks like this PR is missing a test as per the bot message above. Can you please add one? Thank you!

@goderbauer
Copy link
Member

I am going to close this PR since there was no follow-up. We have an issue on file for this. Please feel free to reopen the PR if you find the time to work on this again.

@goderbauer goderbauer closed this Mar 5, 2024
@prasadsunny1 prasadsunny1 mentioned this pull request Mar 11, 2024
9 tasks
@prasadsunny1
Copy link
Contributor

Hi @goderbauer I tried competing the work of the previous PR, please check. It seems like all checks have passed, please let me know if I should improve the test

auto-submit bot pushed a commit that referenced this pull request Mar 18, 2024
*Continuing work from the PR #140373

Add the ability to set route settings on PopupMenuButton

Fixes #140372

Added UTs as requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to set route settings on the menu opened by PopupMenuButton

3 participants