fix: cannot input new line using custom input control #140356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
Satsrag
force-pushed
the
fix_new_line
branch
from
8083943 to
de83b76
Compare
LongCatIsLooong
approved these changes
Dec 21, 2023
Contributor
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
LGTM. Thank you for contributing!
Satsrag
force-pushed
the
fix_new_line
branch
from
f80be81 to
494ae8e
Compare
Renzo-Olivares
approved these changes
Dec 27, 2023
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM thank you for the contribution!
Contributor
|
@Satsrag Happy new year! It appears that the PR is failing the google testing check, it's likely because the commits are a bit behind. Could you rebase the branch to upstream/main and squash the commits to rerun that test? |
LongCatIsLooong
added
the
autosubmit
Contributor
Author
|
Thanks for all of this work. Happy new year! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 5, 2024
This was referenced Feb 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #125875 and flutter/engine#45522
According to this discussion, Just added
forceMultilineto JSON on_configurationToJson. @LongCatIsLooong @Renzo-Olivares