Skip to content

Fixes #138773, port autocomplete to OverlayPortal #140285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Jan 24, 2024
Merged

Fixes #138773, port autocomplete to OverlayPortal #140285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07bd75a
wip
LongCatIsLooong Dec 17, 2023
4f7910d
Fixes #138773, port autocomplete to OverlayPortal
LongCatIsLooong Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/flutter/lib/src/material/autocomplete.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ class Autocomplete<T extends Object> extends StatelessWidget {
displayStringForOption: displayStringForOption,
onSelected: onSelected,
options: options,
openDirection: optionsViewOpenDirection,
maxOptionsHeight: optionsMaxHeight,
);
},
Expand Down Expand Up @@ -166,21 +167,27 @@ class _AutocompleteOptions<T extends Object> extends StatelessWidget {
super.key,
required this.displayStringForOption,
required this.onSelected,
required this.openDirection,
required this.options,
required this.maxOptionsHeight,
});

final AutocompleteOptionToString<T> displayStringForOption;

final AutocompleteOnSelected<T> onSelected;
final OptionsViewOpenDirection openDirection;

final Iterable<T> options;
final double maxOptionsHeight;

@override
Widget build(BuildContext context) {
final AlignmentDirectional optionsAlignment = switch (openDirection) {
OptionsViewOpenDirection.up => AlignmentDirectional.bottomStart,
OptionsViewOpenDirection.down => AlignmentDirectional.topStart,
};
return Align(
alignment: Alignment.topLeft,
alignment: optionsAlignment,
child: Material(
elevation: 4.0,
child: ConstrainedBox(
Expand Down
Loading