Tiny fix inaccurate documentations about bindings #140282

fzyzcjy · 2023-12-16T23:55:33Z

The old doc says that, AutomatedTestWidgetsFlutterBinding for flutter test and LiveTestWidgetsFlutterBinding for flutter run. However, suppose we flutter test integration_test/simple_test.dart with the following code:

void main() {
  testWidgets('hi', (WidgetTester tester) async {
    print('hi ${TestWidgetsFlutterBinding.instance} ${Platform.operatingSystem}');
  });
}

We will see: hi <IntegrationTestWidgetsFlutterBinding> ios. Therefore, we see IntegrationTestWidgetsFlutterBinding is used in a flutter test command, which is contrary to the documentation.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

goderbauer · 2023-12-18T18:10:07Z

packages/flutter_test/lib/src/binding.dart


 /// A variant of [TestWidgetsFlutterBinding] for executing tests in
-/// the `flutter test` environment.
+/// the host environment.


I don't think most people will understand what is meant by "host environment". We should be more specific here. It should probably continue to mention that this binding is typically used when running flutter test - unless it is an integration test.

goderbauer · 2023-12-18T18:10:38Z

packages/flutter_test/lib/src/binding.dart

-/// the `flutter run` environment, on a device. This is intended to
-/// allow interactive test development.
+/// A variant of [TestWidgetsFlutterBinding] for executing tests
+/// on a device. This is intended to allow interactive test development.


this should also continue to mention flutter run as a typical way.

goderbauer · 2024-01-09T23:56:47Z

packages/flutter_test/lib/src/binding.dart

-/// A variant of [TestWidgetsFlutterBinding] for executing tests in
-/// the `flutter test` environment.
+/// A variant of [TestWidgetsFlutterBinding] for executing tests typically
+/// the `flutter test` environment, unless it is an integration test.


Overall, this will need a little more work to be actually useful. A question I immediately have when reading this new doc is: Okay, but what IS used for integration tests then?

goderbauer

LGTM

Piinks

LGTM!

auto-submit · 2024-01-17T00:07:25Z

auto label is removed for flutter/flutter/140282, Failed to merge flutter/flutter/140282 with Pull request flutter/flutter/140282 could not be merged: Required status check "ci.yaml validation" is queued..

fzyzcjy · 2024-01-17T00:07:54Z

@Piinks I clicked Update branch and hope ci.yaml auto-submit bot said is good now

…utter#140282)

Manual roll Flutter from f77f824 to 684247a (39 revisions) Manual roll requested by [email protected] flutter/flutter@f77f824...684247a 2024-01-19 [email protected] Use Integer instead of int in map in flutter.groovy (flutter/flutter#141895) 2024-01-19 [email protected] Roll Flutter Engine from c953c83112ba to f2b441a26416 (4 revisions) (flutter/flutter#141894) 2024-01-19 [email protected] Native assets: package in framework on iOS and MacOS (flutter/flutter#140907) 2024-01-19 [email protected] Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" (flutter/flutter#141814) 2024-01-19 [email protected] Roll Flutter Engine from 538975f2511b to c953c83112ba (3 revisions) (flutter/flutter#141886) 2024-01-19 [email protected] Add `showDragHandle` to `showBottomSheet` (flutter/flutter#141754) 2024-01-19 [email protected] Roll Flutter Engine from 9a6c64de8a46 to 538975f2511b (8 revisions) (flutter/flutter#141881) 2024-01-19 [email protected] Make pumpWidget's arguments named (flutter/flutter#141728) 2024-01-19 [email protected] Tiny fix inaccurate documentations about bindings (flutter/flutter#140282) 2024-01-19 [email protected] Roll engine to 9a6c64de8a4694cef59a338cd33ac1a9e7d23d9d (flutter/flutter#141870) 2024-01-19 [email protected] Roll Packages from 83c2c4d to 129e08c (13 revisions) (flutter/flutter#141865) 2024-01-19 [email protected] Add mac_x64_ios configuration. (flutter/flutter#141828) 2024-01-19 [email protected] Roll Flutter Engine from 90be25d8aac3 to d1afda52d254 (1 revision) (flutter/flutter#141825) 2024-01-19 [email protected] Move the requestKeyboard up to the widgets layer (flutter/flutter#141655) 2024-01-19 [email protected] Roll Flutter Engine from dde3ebf6551a to 90be25d8aac3 (1 revision) (flutter/flutter#141817) 2024-01-18 [email protected] enable more tests in web mode (flutter/flutter#141791) 2024-01-18 [email protected] Roll Flutter Engine from 9dded186bcff to dde3ebf6551a (2 revisions) (flutter/flutter#141811) 2024-01-18 [email protected] Update margin between label and icon in Tab to better reflect Material specs (flutter/flutter#140698) 2024-01-18 [email protected] Roll Flutter Engine from 3106e08e1219 to 9dded186bcff (2 revisions) (flutter/flutter#141807) 2024-01-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enable native compilation for windows-arm64 " (flutter/flutter#141809) 2024-01-18 [email protected] Run framework_tests_misc in arm64 and x64. (flutter/flutter#141797) 2024-01-18 [email protected] Roll Flutter Engine from f4a4f046b173 to 3106e08e1219 (1 revision) (flutter/flutter#141802) 2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/flutter#141803) 2024-01-18 [email protected] Update labeler.yml (flutter/flutter#141697) 2024-01-18 [email protected] Roll Flutter Engine from 75400c49fa0b to f4a4f046b173 (2 revisions) (flutter/flutter#141800) 2024-01-18 [email protected] Reland "Remove hack from PageView." (flutter/flutter#141533) 2024-01-18 [email protected] ScaleGestureRecognizer pointerCount=2 for trackpad gestures (flutter/flutter#140745) 2024-01-18 [email protected] Roll Flutter Engine from de68e7612948 to 75400c49fa0b (2 revisions) (flutter/flutter#141796) 2024-01-18 [email protected] Run `flutter_gallery_ios__start_up` test on Mac-14 in staging (flutter/flutter#141795) 2024-01-18 [email protected] Roll Flutter Engine from d80fe1cb5854 to de68e7612948 (1 revision) (flutter/flutter#141789) 2024-01-18 [email protected] Enable native compilation for windows-arm64 (flutter/flutter#137618) 2024-01-18 [email protected] [github actions] Fix token issue on actions/checkout package (flutter/flutter#141652) 2024-01-18 [email protected] Roll Flutter Engine from b75d6d80d813 to d80fe1cb5854 (2 revisions) (flutter/flutter#141785) 2024-01-18 [email protected] Revert "Native assets: roll deps" (flutter/flutter#141748) 2024-01-18 [email protected] Deprecate M2 curves (flutter/flutter#134417) 2024-01-18 [email protected] Fix: TextField can inherit `errorStyle` from `InputDecorationTheme`. (flutter/flutter#141227) 2024-01-18 [email protected] Add check for Bank of Brazil security module to Windows Flutter Doctor validators (flutter/flutter#141135) 2024-01-18 [email protected] Fix gradle lints No semantic change should be present. (flutter/flutter#141692) 2024-01-18 [email protected] Roll Packages from 1a2b780 to 83c2c4d (5 revisions) (flutter/flutter#141778) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human ...

Update binding.dart

956fc97

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Dec 16, 2023

goderbauer reviewed Dec 18, 2023

View reviewed changes

Update binding.dart

c7b9319

goderbauer reviewed Jan 9, 2024

View reviewed changes

fzyzcjy added 2 commits January 11, 2024 10:41

Update binding.dart

e3f540d

Merge branch 'master' into patch-46

82546d5

goderbauer approved these changes Jan 16, 2024

View reviewed changes

goderbauer requested a review from Piinks January 16, 2024 23:59

Piinks approved these changes Jan 17, 2024

View reviewed changes

Piinks added d: api docs Issues with https://api.flutter.dev/ autosubmit Merge PR when tree becomes green via auto submit App labels Jan 17, 2024

Merge branch 'master' into patch-46

4b379cc

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2024

github-actions bot removed the d: api docs Issues with https://api.flutter.dev/ label Jan 17, 2024

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2024

auto-submit bot merged commit 9e024fd into flutter:master Jan 19, 2024

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to 9e024fdf3122 (31 revisions) flutter/packages#5943

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

9e024fd Tiny fix inaccurate documentations about bindings (flutter/fl…

df14c2a

…utter#140282)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to cc544169be01 (32 revisions) flutter/packages#5945

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

9e024fd Tiny fix inaccurate documentations about bindings (flutter/fl…

73d3595

…utter#140282)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Roll Flutter from f77f82435a97 to 3563372f0670 (33 revisions) flutter/packages#5946

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

9e024fd Tiny fix inaccurate documentations about bindings (flutter/fl…

4e69576

…utter#140282)

engine-flutter-autoroll mentioned this pull request Jan 19, 2024

Manual roll Flutter from f77f82435a97 to 684247a3c78a (39 revisions) flutter/packages#5948

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2024

9e024fd Tiny fix inaccurate documentations about bindings (flutter/fl…

906840f

…utter#140282)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tiny fix inaccurate documentations about bindings #140282

Tiny fix inaccurate documentations about bindings #140282

Uh oh!

fzyzcjy commented Dec 16, 2023 •

edited

Loading

Uh oh!

goderbauer Dec 18, 2023

Uh oh!

fzyzcjy Dec 19, 2023

Uh oh!

goderbauer Dec 18, 2023

Uh oh!

fzyzcjy Dec 19, 2023

Uh oh!

goderbauer Jan 9, 2024

Uh oh!

fzyzcjy Jan 11, 2024

Uh oh!

goderbauer left a comment

Uh oh!

Piinks left a comment

Uh oh!

auto-submit bot commented Jan 17, 2024

Uh oh!

fzyzcjy commented Jan 17, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Tiny fix inaccurate documentations about bindings #140282

Tiny fix inaccurate documentations about bindings #140282

Uh oh!

Conversation

fzyzcjy commented Dec 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

goderbauer Dec 18, 2023

Choose a reason for hiding this comment

Uh oh!

fzyzcjy Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

goderbauer Dec 18, 2023

Choose a reason for hiding this comment

Uh oh!

fzyzcjy Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

goderbauer Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

fzyzcjy Jan 11, 2024

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 17, 2024

Uh oh!

fzyzcjy commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fzyzcjy commented Dec 16, 2023 •

edited

Loading

fzyzcjy commented Jan 17, 2024 •

edited

Loading