Migrate Xcode projects last version checks to Xcode 15.1 #140256

jmagman · 2023-12-15T23:16:27Z

Change the following in the flutter create templates. I didn't make any auto-migrations for existing apps because none seem that critical:

Turn on ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS in iOS and macOS.
Turn on BuildIndependentTargetsInParallel in macOS template. https://github.com/flutter/flutter/pull/125827/files#r1181817619
Turn on DEAD_CODE_STRIPPING in macOS template.
Set ENABLE_USER_SCRIPT_SANDBOXING=NO in iOS and macOS template. flutter scripts don't work with this on. This might require a migration in the future to explicitly turn this one off. However at least for now if the setting isn't present it defaults to NO.

Add migration for LastUpgradeVersion so users won't see these validation issues in Xcode.

Run migrator on all the example apps. A few aren't Flutter apps so I edited them in Xcode.

Fixes #140253
See also #125817 and #90304.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman

The first commit in the series is the actual migration and template changes. The second commit is updating all the example and integration test apps.

jmagman · 2023-12-15T23:16:55Z

packages/flutter_tools/lib/src/migrations/xcode_project_object_version_migration.dart

This is the migration.

jmagman · 2023-12-15T23:25:10Z

...ages/flutter_tools/templates/app_shared/ios-swift.tmpl/Runner.xcodeproj/project.pbxproj.tmpl

Xcode wanted to rearrange this.

jmagman · 2023-12-15T23:25:15Z

...ages/flutter_tools/templates/app_shared/ios-swift.tmpl/Runner.xcodeproj/project.pbxproj.tmpl

Xcode wanted to rearrange this.

jmagman · 2023-12-15T23:25:28Z

...ages/flutter_tools/templates/app_shared/ios-swift.tmpl/Runner.xcodeproj/project.pbxproj.tmpl

jmagman · 2023-12-15T23:26:22Z

...ages/flutter_tools/templates/app_shared/ios-swift.tmpl/Runner.xcodeproj/project.pbxproj.tmpl

Xcode didn't like this either.

vashworth

Can you also update https://github.com/flutter/flutter/tree/master/packages/flutter_tools/templates/xcode/ios/custom_application_bundle?

vashworth · 2023-12-19T16:51:40Z

dev/integration_tests/flutter_gallery/macos/Podfile.lock

I think the CocoaPods version in CI is 1.13, will this cause any issues do you think?

I don't think it matters since the tests pass, but I'll revert this since it's not related just in case it does cause issues.

gspencergoog · 2023-12-20T19:43:32Z

cc @cbracken

jmagman · 2023-12-20T20:52:21Z

Can you also update https://github.com/flutter/flutter/tree/master/packages/flutter_tools/templates/xcode/ios/custom_application_bundle?

I think I did? Did I miss a spot?

https://github.com/flutter/flutter/pull/140256/files#diff-f5b1780c3c9431b0b8bf819ce041321d596d86eb5a6cf4b2763bdb7d40838611R66

vashworth

LGTM

auto-submit · 2023-12-21T18:49:06Z

auto label is removed for flutter/flutter/140256, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

cbracken

lgtm 🎉 Thanks!

…tter/flutter#140256)

Manual roll Flutter from 11def8e to cc40425 (118 revisions) Manual roll requested by [email protected] flutter/flutter@11def8e...cc40425 2024-01-05 [email protected] Roll Flutter Engine from 0bbb4d61ce82 to f60d9a9a3395 (1 revision) (flutter/flutter#140993) 2024-01-04 [email protected] Roll Flutter Engine from b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (flutter/flutter#140990) 2024-01-04 [email protected] [web] Fix and unskip a few more CanvasKit tests (flutter/flutter#140821) 2024-01-04 [email protected] Roll Flutter Engine from bd175aa5e0b6 to b2a9ce88a19e (1 revision) (flutter/flutter#140986) 2024-01-04 [email protected] Pin package:vm_service (flutter/flutter#140972) 2024-01-04 [email protected] Add scrollbar for menus (flutter/flutter#140941) 2024-01-04 [email protected] manual pub roll to pick up dds fixes (flutter/flutter#140979) 2024-01-04 [email protected] Roll Flutter Engine from b81023eb71c9 to bd175aa5e0b6 (2 revisions) (flutter/flutter#140980) 2024-01-04 [email protected] Temporarily remove env variable for leak tracking bots. (flutter/flutter#140978) 2024-01-04 [email protected] Add Flutter CI status to README (flutter/flutter#140513) 2024-01-04 [email protected] Reland "integrate testWidgets with leak tracking" (#140521) (flutter/flutter#140928) 2024-01-04 [email protected] Run half of iOS devicelab tests with Xcode 15 (flutter/flutter#140927) 2024-01-04 [email protected] Fix `SegmentedButton` states update logic (flutter/flutter#140772) 2024-01-04 [email protected] Roll Flutter Engine from f539acfb8c5a to b81023eb71c9 (1 revision) (flutter/flutter#140973) 2024-01-04 [email protected] [Fix] Consistency in ButtonStyleButton related Tests (flutter/flutter#140610) 2024-01-04 [email protected] Roll Packages from bbb4134 to 31fc7b5 (6 revisions) (flutter/flutter#140967) 2024-01-04 [email protected] Fix local engine use in macOS plugins (flutter/flutter#140222) 2024-01-04 [email protected] Roll Flutter Engine from 7d5a120a601b to f539acfb8c5a (2 revisions) (flutter/flutter#140959) 2024-01-04 [email protected] Roll Flutter Engine from 1ff3cb885842 to 7d5a120a601b (1 revision) (flutter/flutter#140946) 2024-01-04 [email protected] Roll Flutter Engine from c8bf51f0d4cd to 1ff3cb885842 (1 revision) (flutter/flutter#140943) 2024-01-04 [email protected] Roll Flutter Engine from bfd2d8a100ec to c8bf51f0d4cd (2 revisions) (flutter/flutter#140939) 2024-01-04 [email protected] Roll Flutter Engine from 28ae9e35c331 to bfd2d8a100ec (1 revision) (flutter/flutter#140937) 2024-01-04 [email protected] Roll Flutter Engine from ab4098c742f8 to 28ae9e35c331 (1 revision) (flutter/flutter#140936) 2024-01-04 [email protected] Roll Flutter Engine from e169f3677008 to ab4098c742f8 (2 revisions) (flutter/flutter#140933) 2024-01-03 [email protected] Roll Flutter Engine from 7c2adb811059 to e169f3677008 (1 revision) (flutter/flutter#140929) 2024-01-03 [email protected] Remove deprecated bitcode stripping from tooling (flutter/flutter#140903) 2024-01-03 [email protected] Add Windows leak tracking targets (flutter/flutter#140423) 2024-01-03 [email protected] [github actions] refactor and fix cherry pick actions (flutter/flutter#140499) 2024-01-03 [email protected] Migrate Xcode projects last version checks to Xcode 15.1 (flutter/flutter#140256) 2024-01-03 [email protected] Roll Flutter Engine from bf232c4da241 to 7c2adb811059 (3 revisions) (flutter/flutter#140920) 2024-01-03 [email protected] fix typo and reflow (flutter/flutter#140925) 2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Re-land integrate testWidgets with leak tracking." (flutter/flutter#140926) 2024-01-03 [email protected] Roll Flutter Engine from bf979d220283 to bf232c4da241 (1 revision) (flutter/flutter#140915) 2024-01-03 [email protected] Changes the regular cursor to a floating cursor when a long press occurs. (flutter/flutter#138479) 2024-01-03 [email protected] Add `SegmentedButton.styleFrom` (flutter/flutter#137542) 2024-01-03 [email protected] Roll Flutter Engine from c62bcff5b809 to bf979d220283 (1 revision) (flutter/flutter#140910) 2024-01-03 [email protected] Re-land integrate testWidgets with leak tracking. (flutter/flutter#140521) 2024-01-03 [email protected] Roll Flutter Engine from 98b72c7ffe71 to c62bcff5b809 (2 revisions) (flutter/flutter#140905) 2024-01-03 [email protected] [flutter_tools] add support for --enable-impeller to test device. (flutter/flutter#140899) 2024-01-03 [email protected] Roll Flutter Engine from cf7536964a2f to 98b72c7ffe71 (1 revision) (flutter/flutter#140897) 2024-01-03 [email protected] Handle KEYCODE_DPAD_CENTER and KEYCODE_ENTER (flutter/flutter#140808) 2024-01-03 [email protected] Add Lucas Saudon to AUTHORS (flutter/flutter#139965) 2024-01-03 [email protected] Link to wiki page about updating dependencies in each `pubspec.yaml` file (flutter/flutter#140826) 2024-01-03 [email protected] Marks Linux_pixel_7pro native_assets_android to be unflaky (flutter/flutter#140866) ... --------- Co-authored-by: Tarrin Neal <[email protected]>

…tter/flutter#140256)

jmagman added the t: xcode "xcodebuild" on iOS and general Xcode project management label Dec 15, 2023

jmagman self-assigned this Dec 15, 2023

jmagman force-pushed the xcode-15-build-settings branch from 86baefb to 140e0a9 Compare December 15, 2023 23:24

jmagman commented Dec 15, 2023

View reviewed changes

jmagman force-pushed the xcode-15-build-settings branch from 140e0a9 to d6f0468 Compare December 15, 2023 23:32

jmagman requested a review from vashworth December 16, 2023 00:12

vashworth reviewed Dec 19, 2023

View reviewed changes

jmagman requested a review from cbracken December 20, 2023 20:46

jmagman force-pushed the xcode-15-build-settings branch from d6f0468 to 6afb504 Compare December 20, 2023 20:53

vashworth approved these changes Dec 21, 2023

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2023

jmagman added 3 commits December 21, 2023 11:21

Migrate Xcode projects last version checks to Xcode 15.1

c9d0ed6

Update example and integration test apps

5735a64

Revert pod change

f09d91c

jmagman force-pushed the xcode-15-build-settings branch from 6afb504 to f09d91c Compare December 21, 2023 19:21

Merge branch 'master' into xcode-15-build-settings

9025eec

cbracken approved these changes Jan 3, 2024

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

auto-submit bot merged commit 076cb8a into flutter:master Jan 3, 2024

engine-flutter-autoroll mentioned this pull request Jan 5, 2024

Manual roll Flutter from 11def8eff455 to cc40425ddcef (118 revisions) flutter/packages#5806

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024

076cb8a Migrate Xcode projects last version checks to Xcode 15.1 (flu…

8794e48

…tter/flutter#140256)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

076cb8a Migrate Xcode projects last version checks to Xcode 15.1 (flu…

6ce9e11

…tter/flutter#140256)

jmagman mentioned this pull request Nov 20, 2024

[flutter_tools] opt iOS/macOS apps out of Metal API validation via migrator, update templates in repo. #159228

Merged

Migrate Xcode projects last version checks to Xcode 15.1 #140256

Migrate Xcode projects last version checks to Xcode 15.1 #140256

Uh oh!

Conversation

jmagman commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

vashworth left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

gspencergoog commented Dec 20, 2023

Uh oh!

jmagman commented Dec 20, 2023

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Dec 21, 2023

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmagman commented Dec 15, 2023 •

edited

Loading

vashworth left a comment •

edited

Loading