Skip to content

Reorganize dependencies on leak_tracker. #140233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Dec 15, 2023
Merged

Reorganize dependencies on leak_tracker. #140233

auto-submit merged 3 commits into from
Dec 15, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Dec 15, 2023 •
edited
Loading

  1. Move leak_tracker and leak_tracker_testing out of direct dependencies.
  2. Move leak_tracker_flutter_testing from dev to prod dependencies for flutter_test

It is prerequisite for #135856

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Dec 15, 2023
@polina-c polina-c mentioned this pull request Dec 15, 2023
Closed
24 tasks
christopherfujino
christopherfujino approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 15, 2023

auto label is removed for flutter/flutter/140233, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023
@auto-submit auto-submit bot merged commit bda158a into flutter:master Dec 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023
@engine-flutter-autoroll
bda158a Reorganize dependencies on leak_tracker. (flutter/flutter#140233
eb6e9d0 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023
@engine-flutter-autoroll
bda158a Reorganize dependencies on leak_tracker. (flutter/flutter#140233
85a6242 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023
@engine-flutter-autoroll
bda158a Reorganize dependencies on leak_tracker. (flutter/flutter#140233
418079c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023
@engine-flutter-autoroll
bda158a Reorganize dependencies on leak_tracker. (flutter/flutter#140233
09deecb 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023
@engine-flutter-autoroll
bda158a Reorganize dependencies on leak_tracker. (flutter/flutter#140233
d9deb15 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
bda158a Reorganize dependencies on leak_tracker. (flutter/flutter#140233
0639246 
)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 18, 2023
@engine-flutter-autoroll
Roll Flutter from 2407f69 to cdc83e5 (28 revisions) (#5715)
be52ac8 
flutter/flutter@2407f69...cdc83e5

2023-12-18 [email protected] Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (flutter/flutter#140309)
2023-12-18 [email protected] refactored cli tool ipa method name to support --export-options-plist (flutter/flutter#138555)
2023-12-18 [email protected] Restore and fix flavors_test_macos (flutter/flutter#139841)
2023-12-18 [email protected] Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (flutter/flutter#140308)
2023-12-17 [email protected] Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (flutter/flutter#140291)
2023-12-17 [email protected] Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (flutter/flutter#140289)
2023-12-16 [email protected] Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) (flutter/flutter#140280)
2023-12-16 [email protected] Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) (flutter/flutter#140277)
2023-12-16 [email protected] Center Floating Snackbar with custom width when direction is RTL (flutter/flutter#140215)
2023-12-16 [email protected] Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (flutter/flutter#140274)
2023-12-16 [email protected] Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942)
2023-12-16 [email protected] Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (flutter/flutter#140270)
2023-12-16 [email protected] Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (flutter/flutter#140268)
2023-12-16 [email protected] Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (flutter/flutter#140265)
2023-12-16 [email protected] Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (flutter/flutter#140263)
2023-12-16 [email protected] Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (flutter/flutter#140262)
2023-12-16 [email protected] [github actions] minor PR to test latest github actions (flutter/flutter#140252)
2023-12-16 [email protected] Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (flutter/flutter#140255)
2023-12-15 [email protected] Remove usage of testWidgetsWithLeakTracking. (flutter/flutter#140239)
2023-12-15 [email protected] Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (flutter/flutter#140244)
2023-12-15 [email protected] Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (flutter/flutter#140240)
2023-12-15 [email protected] Use new `enabledFeature` param for `Analytics` (flutter/flutter#139934)
2023-12-15 [email protected] Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (flutter/flutter#140236)
2023-12-15 [email protected] Reorganize dependencies on leak_tracker. (flutter/flutter#140233)
2023-12-15 [email protected] [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/flutter#135447)
2023-12-15 [email protected] Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (flutter/flutter#140230)
2023-12-15 [email protected] Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (flutter/flutter#140228)
2023-12-15 [email protected] Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (flutter/flutter#140224)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
bda158a Reorganize dependencies on leak_tracker. (flutter/flutter#140233
68a8ebc 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @christopherfujino