Reland "Warn when Gradle plugins are applied using the legacy apply script method #140103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
…ethod" way (#139690) This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle)). See also: - #121541 - in particular #121541 (comment) - #135392 - and PR that add the migration guide: [#9857](flutter/website#9857) - I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).
Member
Author
|
I run |
Member
Author
|
polite ping @reidbaker :) |
Contributor
|
Hey I was on vacation, should get to this tomorrow |
reidbaker
approved these changes
Dec 19, 2023
bartekpacia
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 19, 2023
… apply script method (flutter/flutter#140103)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 19, 2023
… apply script method (flutter/flutter#140103)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 19, 2023
flutter/flutter@cdc83e5...0eb7881 2023-12-19 [email protected] Shift some Linux-hosted tests on moto g4 to pixel 7 (flutter/flutter#140389) 2023-12-19 [email protected] Reland "Warn when Gradle plugins are applied using the legacy apply script method (flutter/flutter#140103) 2023-12-19 [email protected] Roll Packages from d7dee79 to be52ac8 (1 revision) (flutter/flutter#140386) 2023-12-19 [email protected] Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (flutter/flutter#140371) 2023-12-19 [email protected] Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (flutter/flutter#140367) 2023-12-19 [email protected] Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (flutter/flutter#140362) 2023-12-19 [email protected] Upgrade to version of leak tracker that does not depend on test_widgets. (flutter/flutter#140247) 2023-12-19 [email protected] Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) (flutter/flutter#140359) 2023-12-18 [email protected] Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) (flutter/flutter#140350) 2023-12-18 [email protected] SemanticsProperties: default `identifier` and `tooltip` to null (flutter/flutter#140283) 2023-12-18 [email protected] Document difference between softWrap and maxLine (flutter/flutter#139363) 2023-12-18 [email protected] Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) (flutter/flutter#140332) 2023-12-18 [email protected] Only run dart files as a test in the Android preview tools test shard (flutter/flutter#140099) 2023-12-18 [email protected] Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) (flutter/flutter#140328) 2023-12-18 [email protected] Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) (flutter/flutter#140324) 2023-12-18 [email protected] Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter/flutter#140322) 2023-12-18 [email protected] Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) (flutter/flutter#140320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…cript method (flutter#140103) > This PR relands flutter#139690 which was reverted in flutter#140102 This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle)). See also: - flutter#121541 - in particular flutter#121541 (comment) - flutter#135392 - and PR that add the migration guide: [flutter#9857](flutter/website#9857) - I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
… apply script method (flutter/flutter#140103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is:
flutter.gradleandapp_plugin_loader.gradle).See also:
Migrate Gradle plugin to Kotlin, away from Groovy #121541
Add documentation for migrating Android build files to declarative form #135392
I think either
logger.errororlogger.quietmust be used, because all other error levels are not shown duringflutter build apk(and that's what most people use).Pre-launch Checklist
///).