Added onEnd callback into AnimatedSize #139859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
goderbauer
reviewed
Dec 15, 2023
| } | ||
|
|
||
| void _animationStatusListener(AnimationStatus status) { | ||
| if (status == AnimationStatus.completed) { |
Member
There was a problem hiding this comment.
This should be a switch per our style guide: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-if-chains-or--or--with-enum-values
|
|
||
| class _AnimatedSizeState | ||
| extends State<AnimatedSize> with SingleTickerProviderStateMixin { | ||
| extends State<AnimatedSize> with SingleTickerProviderStateMixin { |
Member
There was a problem hiding this comment.
please undo this whitespace change
| ), | ||
| ); | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
nit: remove one of the blank lines
| }); | ||
|
|
||
| testWidgetsWithLeakTracking('calls onEnd when animation is completed', (WidgetTester tester) async { | ||
| await tester.pumpWidget( |
Member
There was a problem hiding this comment.
You can simplify this. remove the mockOnEndFunction stuff and just define an inline function here:
int callCount = 0;
void handleEnd() {
callCount++;
}and then just pass handleEnd wherever you need it
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 20, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 20, 2023
flutter/flutter@0eb7881...da0cd69 2023-12-20 [email protected] Revert automated changes made to deprecated settings.gradle (plugins.each) (flutter/flutter#140037) 2023-12-20 [email protected] [github actions] change minimal example workflow to be manually dispatched (flutter/flutter#140435) 2023-12-20 [email protected] Make `TextSpan` hit testing precise. (flutter/flutter#139717) 2023-12-20 [email protected] [github actions] add minimal workflow to test token (flutter/flutter#140363) 2023-12-20 [email protected] Roll Flutter Engine from 5279873a8635 to c70f0a495ace (2 revisions) (flutter/flutter#140431) 2023-12-20 [email protected] Roll Flutter Engine from df1593e96a6b to 5279873a8635 (2 revisions) (flutter/flutter#140428) 2023-12-20 [email protected] [flutter_tools] handle FileSystemException trying to delete temp directory from core_devices.dart (flutter/flutter#140415) 2023-12-19 [email protected] Move hybrid_android_views_integration_test back to Moto G4 (flutter/flutter#140421) 2023-12-19 [email protected] Roll Flutter Engine from 3b156c8ce9bd to df1593e96a6b (2 revisions) (flutter/flutter#140422) 2023-12-19 [email protected] Added onEnd callback into AnimatedSize (flutter/flutter#139859) 2023-12-19 [email protected] Roll Flutter Engine from 3f45f9db4471 to 3b156c8ce9bd (1 revision) (flutter/flutter#140413) 2023-12-19 [email protected] Roll Flutter Engine from 187334c39b44 to 3f45f9db4471 (3 revisions) (flutter/flutter#140412) 2023-12-19 [email protected] Remove workarounds for `plugin_lint_mac` needed for older version of Cocoapods (flutter/flutter#140395) 2023-12-19 [email protected] Roll Flutter Engine from b87a782ce3a3 to 187334c39b44 (2 revisions) (flutter/flutter#140398) 2023-12-19 [email protected] Roll Flutter Engine from 1d5a141917fa to b87a782ce3a3 (1 revision) (flutter/flutter#140390) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
XilaiZhang
added
cp: beta
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #106439
Pre-launch Checklist
///).