Repository navigation
If one method of finding Dart VM fails for CoreDevice, wait for the other method - #139754
Merged
auto-submit[bot] merged 1 commit intoDec 8, 2023
Merged
Conversation
github-actions
Bot
added
platform-ios
vashworth
marked this pull request as ready for review
December 7, 2023 21:54
| <Future<Uri?>>[vmUrlFromMDns, vmUrlFromLogs] | ||
| ); | ||
|
|
||
| // If the first future to return is null, wait for the other to complete. |
Contributor
There was a problem hiding this comment.
this is ugly, but I can't think of a less ugly way to handle this, so SGTM.
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
…or the other method (flutter/flutter#139754)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
…or the other method (flutter/flutter#139754)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
…or the other method (flutter/flutter#139754)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 8, 2023
…or the other method (flutter/flutter#139754)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
…or the other method (flutter/flutter#139754)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CoreDevices we use a combination of mDNS and device logs to find the Dart VM url. If mDNS fails first, it will cause the launch to fail even though the device logs may be able to find the url. So if one of the methods fails, wait for the other method before failing the launch.
Fixes #139685.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.