Keyboard doesn't dismiss when the drawer comes up #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
There was a problem hiding this comment.
this function is now unused as far as I can tell, and focusedScope should now be final.
Contributor
|
lgtm. we should add some more tests though. |
Contributor
Author
Added test. |
When introducing Focus widgets for the Drawer (and ModalRoutes), we weren't actually giving them the focus. Now we move the focus scope when pushing modal routes. Fixes flutter#184
abarth
added a commit
that referenced
this pull request
Jan 27, 2016
Keyboard doesn't dismiss when the drawer comes up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing Focus widgets for the Drawer (and ModalRoutes), we weren't
actually giving them the focus. Now we move the focus scope when pushing modal
routes.
Fixes #184