Skip to content

[ci.yaml] Add runif filters and stricter timeout to packaging_test - #139694

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
CaseyHillers:fix-packaging-flake
Dec 6, 2023
Merged

[ci.yaml] Add runif filters and stricter timeout to packaging_test#139694
auto-submit[bot] merged 1 commit into
flutter:masterfrom
CaseyHillers:fix-packaging-flake

Conversation

@CaseyHillers

@CaseyHillers CaseyHillers commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

#139597

  • Remove beta and stable filters as the Cocoon scheduler doesn't run on these branches

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

christopherfujino
christopherfujino reviewed Dec 6, 2023
View reviewed changes
Comment thread .ci.yaml

- name: Linux flutter_packaging_test
recipe: packaging/packaging
timeout: 60

@christopherfujino christopherfujino Dec 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the default? i thought 60 WAS the default.

@CaseyHillers CaseyHillers Dec 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 30 minutes. Ideally, we would have a tool that gets historical data to send PRs to change this, but I'm not sure how to get the BigQuery data from Dart.

https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/model/proto/internal/scheduler.proto;l=40

@christopherfujino christopherfujino Dec 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

christopherfujino
christopherfujino approved these changes Dec 6, 2023
View reviewed changes

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question about what the default timeout is

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit
auto-submit Bot merged commit 9ef1c2b into flutter:master Dec 6, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
821ad60 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
ad86c62 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
29881e6 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
f3f7ac3 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
3b2cab2 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
58f3b86 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
c169e98 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
845bad1 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
c58cad2 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
a74f1bf 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
6388da6 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
e452269 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
c0c5168 
…_test (flutter/flutter#139694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
ba47b99 
…_test (flutter/flutter#139694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
9ef1c2b [ci.yaml] Add runif filters and stricter timeout to packaging…
28b69db 
…_test (flutter/flutter#139694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@christopherfujino christopherfujino christopherfujino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaseyHillers @christopherfujino