Skip to content

Implement SubmenuButton.onFocusChange - #139678

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
QuncCccccc:fix_on_focused_change
Dec 7, 2023
Merged

Implement SubmenuButton.onFocusChange#139678
auto-submit[bot] merged 1 commit into
flutter:masterfrom
QuncCccccc:fix_on_focused_change

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Fixes #139409

SubmenuButton.onFocusChange is not implemented. This PR is just add one line fix to assign this property to TextButton.onFocusChange which is used in SubmenuButton:)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Dec 6, 2023
@QuncCccccc
QuncCccccc marked this pull request as ready for review December 6, 2023 20:05
gspencergoog
gspencergoog approved these changes Dec 7, 2023
View reviewed changes

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
@auto-submit
auto-submit Bot merged commit 613a0ac into flutter:master Dec 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
44d7636
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
9a92649
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
7f86cf8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
91ae19f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
44d6e76
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
df8f49c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
fd7f0a4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
a6f8541
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
4c095da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
97d62dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
dd03ece
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
a84b0a4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
f1953f0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
613a0ac Implement SubmenuButton.onFocusChange (flutter/flutter#139678)
302129e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[material] SubmenuButton onFocusChange isn't implemented

2 participants

@QuncCccccc @gspencergoog