Skip to content

Roll dependencies - #139606

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Hixie:roll_deps
Dec 6, 2023
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
Hixie:roll_deps

Conversation

@Hixie

@Hixie Hixie commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

test-exempt: rolling dependencies

@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Dec 5, 2023

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. out of curiosity do you need something from this roll?

@christopherfujino

Copy link
Copy Markdown
Contributor

Ahh, the autoroll PR had failing tests: #139589. If presubmits pass here i'll manually close that one.

@christopherfujino

Copy link
Copy Markdown
Contributor

I'm guessing customer_testing failures are legit then?

@Hixie

Hixie commented Dec 6, 2023

Copy link
Copy Markdown
Contributor Author

I wanted to submit a PR that updated a pubspec.yaml, so I needed the dependencies to be up to date. I forgot we have a bot that does this these days.

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit

auto-submit Bot commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/139606, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit

auto-submit Bot commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/139606, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit
auto-submit Bot merged commit fca7bc9 into flutter:master Dec 6, 2023
@CaseyHillers

Copy link
Copy Markdown
Contributor

I marked the Google testing check as skipped. It failed on merge conflicts with the pubspec, and we only have an allowlist for the pub roller bots to ignore the pubspec failures.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants