Skip to content

[beta-cherrypick] cherrypicks commit 7d9010c3578338bc850d66c315bd6086f3d3dc9a from PR #139594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XilaiZhang wants to merge 2 commits into from
Closed

[beta-cherrypick] cherrypicks commit 7d9010c3578338bc850d66c315bd6086f3d3dc9a from PR #139594

XilaiZhang wants to merge 2 commits into from

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Dec 5, 2023 •
edited
Loading

This pull request is opened against a release branch.

To request a cherry pick of a commit, please fill in the form below. (Questions with an asterisk are required.)

To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.

A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.

  • Issue Link: What is the link to the issue this cherry-pick is addressing?
  My Answer:



  My Answer:
  • Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
  My Answer:
  • impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
  My Answer:
  • Workaround: Is there a workaround for this issue?
  My Answer:
  • Risk: What is the risk level of this cherry-pick?
  My Answer:
  - [ ] Low
  - [ ] Medium
  - [ ] High
  • Test Coverage: Are you confident that your fix is well-tested by automated tests?
  My Answer:
  - [ ] Yes
  - [ ] No
  • Validation Steps: What are the steps to validate that this fix works?
  My Answer:

mdebbar and others added 2 commits December 5, 2023 21:54
@mdebbar
Typo fix in dartdoc in tool test (#139386)
80c3a43 
The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in flutter/tests#317 and an
issue was filed at macosui/macos_ui#499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.
@XilaiZhang
automated cherry pick
18797c1
@XilaiZhang XilaiZhang force-pushed the create-pull-request/patch branch from 7e682f7 to 18797c1 Compare December 5, 2023 21:54
@XilaiZhang XilaiZhang added the cp: review Cherry-picks in the review queue label Dec 5, 2023
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 5, 2023
@XilaiZhang XilaiZhang mentioned this pull request Dec 5, 2023
Merged
@XilaiZhang XilaiZhang closed this Dec 5, 2023
@XilaiZhang XilaiZhang mentioned this pull request Dec 5, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

cp: review Cherry-picks in the review queue tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XilaiZhang @fluttergithubbot @mdebbar