Repository navigation
Reset deprecation period for setPubRootDirectories - #139592
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
won't that make the message a lie? |
I think? We've done this a couple of times before to 'extend' the period. Should we create a different mechanism? |
|
Well we shouldn't lie. :-) |
|
I don't think we are lying. This is something we have done several times.
We determine the EOL based on the release tag: https://github.com/flutter/flutter/wiki/Tree-hygiene#deprecations There are scripts based on the very precise wording of these deprecation messages. I think it is fine to propose a change for cases where we need to extend the period, but not in this PR. I don't see why this should be blocked on changing the process when this has already been in practice.
|
|
I guess I didn't realize that when we were changing those messages it was because we were extending the end of the period rather than reflecting a change to when the deprecation happened (e.g. because the deprecation covered new ground, or whatever). The intent of saying "This feature was deprecated after vX" was to indicate that in versions <X it's not deprecated and in versions >X it is, if we just bump the date to extend the period, it no longer accurately describes that as far as I can tell. I agree that we don't have to resolve this in this PR. test-exempt: doesn't affect code semantics |
Piinks
added
framework
This deprecation period is being renewed after we found it affected many IDE plugins that had not yet migrated, but did not receive a warning during the deprecation period.
We also expected to have a migration guide since the migration is not always to simply rename to addPubRootDirectories. This will give another 1+ year for the migration to be completed.
Part of #139243
Will update announcement at flutter-announce to reflect this API will remain for a while longer.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.