[flutter release] Add cherry pick template for pull request description #139590
Conversation
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
Instead of creating duplicate templates, let's reuse https://github.com/flutter/flutter/blob/master/.github/ISSUE_TEMPLATE/7_cherry_pick.yml. As we migrate off of creating issues, and using the PRs directly, we can clean up the template.
|
Right the current template had to be adapted from the web form issue template(https://github.com/flutter/flutter/blob/master/.github/ISSUE_TEMPLATE/7_cherry_pick.yml). The pull request template only supports markdown, and a direct copy and paste of web form issue template would cause texts to be corrupted (#139405) The current PR template is in markdown format so that it can be displayed correctly in a PR description (e.g. #139594) |
|
I defer to Kevin. I lean towards us updating the template so it can support both use cases, but he has more context on the how. |
|
@XilaiZhang is the point of this template to be directly consumed by the github action you are creating and used in the body of the automated cherry-pick request? If that is the case, we should prefer to create the template in a separate folder inside of .github to avoid confusion and separate concerns. @CaseyHillers Xilai is correct in stating that we can not reuse the current issue template for |
That makes sense to me, I'm more interested if we should convert this to a markdown template so we can share them between CP issues and PRs. I think it's fine to keep both as well. |
| **To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords. <br> | ||
| A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.** | ||
|
|
||
| * Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers |
There was a problem hiding this comment.
This is missing the section with the original issue
There was a problem hiding this comment.
Sure, added the original issue field.
Also added text box styling around the answers fields, it now looks like the PR description of #139594.
I looked into colored blocks but looks like they are for alerts and not regular text blocks.
The community has already done the work of converting most of our markdown issue templates to the new YAML format. There is no news, but I am holding out hope that PR templates can use the YAML format in the future. I think we should stick to the YAML format where possible. |
Sure, moved to a separate folder |
XilaiZhang
added
the
autosubmit
Manual roll requested by [email protected] flutter/flutter@c642f4e...9719097 2023-12-11 [email protected] Roll Flutter Engine from 5587d26aa2d4 to 4c309195b79d (1 revision) (flutter/flutter#139936) 2023-12-11 [email protected] Fix SelectionArea select-word edge cases (flutter/flutter#136920) 2023-12-11 [email protected] Roll Flutter Engine from 9b85b76db0de to 5587d26aa2d4 (3 revisions) (flutter/flutter#139933) 2023-12-11 [email protected] Roll Flutter Engine from 7eb6b7cab60c to 9b85b76db0de (2 revisions) (flutter/flutter#139931) 2023-12-11 [email protected] Use dart analyze package for `num.clamp` (flutter/flutter#139867) 2023-12-11 [email protected] Roll pub packages (flutter/flutter#139926) 2023-12-11 [email protected] Handle the case when _CupertinoBackGestureDetector is disposed during the drag. (flutter/flutter#139585) 2023-12-11 [email protected] Add accessibility identifier to `SemanticsProperties` (flutter/flutter#138331) 2023-12-11 [email protected] Improve slider's value indicator display test (flutter/flutter#139198) 2023-12-11 [email protected] Add `enabled` property to `ExpansionTile` (flutter/flutter#139519) 2023-12-11 [email protected] Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter/flutter#139911) 2023-12-11 [email protected] Roll Flutter Engine from bc0222b64c96 to 7eb6b7cab60c (1 revision) (flutter/flutter#139891) 2023-12-10 [email protected] Roll Flutter Engine from fb80aafd259b to bc0222b64c96 (1 revision) (flutter/flutter#139885) 2023-12-09 [email protected] Roll pub packages (flutter/flutter#139864) 2023-12-09 [email protected] Roll Flutter Engine from b75960a5820a to fb80aafd259b (1 revision) (flutter/flutter#139863) 2023-12-09 [email protected] Roll Flutter Engine from e80c090d09c6 to b75960a5820a (1 revision) (flutter/flutter#139853) 2023-12-09 [email protected] Roll Flutter Engine from 101396fd3b82 to e80c090d09c6 (2 revisions) (flutter/flutter#139851) 2023-12-09 [email protected] Roll Flutter Engine from 503584615fd7 to 101396fd3b82 (2 revisions) (flutter/flutter#139847) 2023-12-09 [email protected] Roll Flutter Engine from e9cb19fa637a to 503584615fd7 (1 revision) (flutter/flutter#139837) 2023-12-08 [email protected] Roll Flutter Engine from 7dc51b85a634 to e9cb19fa637a (1 revision) (flutter/flutter#139831) 2023-12-08 [email protected] [flutter release] Add cherry pick template for pull request description (flutter/flutter#139590) 2023-12-08 [email protected] Roll Flutter Engine from 03c5f016e919 to 7dc51b85a634 (1 revision) (flutter/flutter#139829) 2023-12-08 [email protected] Add Overlay.wrap for convenience (flutter/flutter#139823) 2023-12-08 [email protected] Roll Flutter Engine from 72da960e2ef2 to 03c5f016e919 (1 revision) (flutter/flutter#139826) 2023-12-08 [email protected] Roll Flutter Engine from 5dd2619c282b to 72da960e2ef2 (1 revision) (flutter/flutter#139821) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
context: #139524 (comment)
Adds a pull request template for automated flutter cherry picks.
This template is adapted from web form cherry pick issue template since PR template doesn't support web form.
This would provide the template to allow #139524 to land