Skip to content

Conversation

@mateusfccp
Copy link
Contributor

@mateusfccp mateusfccp commented Dec 4, 2023

Adds an enabled property to ExpansionTile that allows the user to disable the internal ListTile, so that we can prevent user interaction.

Fixes #135770.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@mateusfccp mateusfccp force-pushed the add_enabled_to_expansion_tile branch 2 times, most recently from 2392890 to 27f1f46 Compare December 5, 2023 10:14
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 5, 2023
@mateusfccp mateusfccp force-pushed the add_enabled_to_expansion_tile branch from 27f1f46 to 819ef17 Compare December 5, 2023 10:43
Signed-off-by: Mateus Felipe C. C. Pinto <[email protected]>
@mateusfccp mateusfccp force-pushed the add_enabled_to_expansion_tile branch from 819ef17 to da7d9ea Compare December 6, 2023 10:42
@HansMuller HansMuller requested a review from QuncCccccc December 8, 2023 22:35
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for the contribution:)

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot merged commit 72aafe8 into flutter:master Dec 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
@mateusfccp mateusfccp deleted the add_enabled_to_expansion_tile branch December 11, 2023 16:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 12, 2023
Manual roll requested by [email protected]

flutter/flutter@c642f4e...9719097

2023-12-11 [email protected] Roll Flutter Engine from 5587d26aa2d4 to 4c309195b79d (1 revision) (flutter/flutter#139936)
2023-12-11 [email protected] Fix SelectionArea select-word edge cases (flutter/flutter#136920)
2023-12-11 [email protected] Roll Flutter Engine from 9b85b76db0de to 5587d26aa2d4 (3 revisions) (flutter/flutter#139933)
2023-12-11 [email protected] Roll Flutter Engine from 7eb6b7cab60c to 9b85b76db0de (2 revisions) (flutter/flutter#139931)
2023-12-11 [email protected] Use dart analyze package for `num.clamp` (flutter/flutter#139867)
2023-12-11 [email protected] Roll pub packages (flutter/flutter#139926)
2023-12-11 [email protected] Handle the case when _CupertinoBackGestureDetector is disposed during the drag.  (flutter/flutter#139585)
2023-12-11 [email protected] Add accessibility identifier to `SemanticsProperties` (flutter/flutter#138331)
2023-12-11 [email protected] Improve slider's value indicator display test (flutter/flutter#139198)
2023-12-11 [email protected] Add `enabled` property to `ExpansionTile` (flutter/flutter#139519)
2023-12-11 [email protected] Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter/flutter#139911)
2023-12-11 [email protected] Roll Flutter Engine from bc0222b64c96 to 7eb6b7cab60c (1 revision) (flutter/flutter#139891)
2023-12-10 [email protected] Roll Flutter Engine from fb80aafd259b to bc0222b64c96 (1 revision) (flutter/flutter#139885)
2023-12-09 [email protected] Roll pub packages (flutter/flutter#139864)
2023-12-09 [email protected] Roll Flutter Engine from b75960a5820a to fb80aafd259b (1 revision) (flutter/flutter#139863)
2023-12-09 [email protected] Roll Flutter Engine from e80c090d09c6 to b75960a5820a (1 revision) (flutter/flutter#139853)
2023-12-09 [email protected] Roll Flutter Engine from 101396fd3b82 to e80c090d09c6 (2 revisions) (flutter/flutter#139851)
2023-12-09 [email protected] Roll Flutter Engine from 503584615fd7 to 101396fd3b82 (2 revisions) (flutter/flutter#139847)
2023-12-09 [email protected] Roll Flutter Engine from e9cb19fa637a to 503584615fd7 (1 revision) (flutter/flutter#139837)
2023-12-08 [email protected] Roll Flutter Engine from 7dc51b85a634 to e9cb19fa637a (1 revision) (flutter/flutter#139831)
2023-12-08 [email protected] [flutter release] Add cherry pick template for pull request description (flutter/flutter#139590)
2023-12-08 [email protected] Roll Flutter Engine from 03c5f016e919 to 7dc51b85a634 (1 revision) (flutter/flutter#139829)
2023-12-08 [email protected] Add Overlay.wrap for convenience (flutter/flutter#139823)
2023-12-08 [email protected] Roll Flutter Engine from 72da960e2ef2 to 03c5f016e919 (1 revision) (flutter/flutter#139826)
2023-12-08 [email protected] Roll Flutter Engine from 5dd2619c282b to 72da960e2ef2 (1 revision) (flutter/flutter#139821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExpansionTile: Support Disabling User Input

3 participants