Skip to content

Update sync-labels to use boolean - #139516

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
drewroengoogle:fix-sync-labels
Dec 4, 2023
Merged

Update sync-labels to use boolean#139516
auto-submit[bot] merged 2 commits into
flutter:masterfrom
drewroengoogle:fix-sync-labels

Conversation

@drewroengoogle

@drewroengoogle drewroengoogle commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

actions/labeler#112 has been fixed, and now requires boolean to be used.

Related infra issue that this fixes: #139511

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@CaseyHillers

CaseyHillers commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Based on how GHA works, you'll need to land this on red as the triager action will not use the new version until this PR is merged.

@drewroengoogle

drewroengoogle commented Dec 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@CaseyHillers Actually, should the entire setting be removed to match what it used to be before the bug? Just updated the commit, let me know if you would prefer if sync-labels be explicitly defined as true (or if you have no preference)

@drewroengoogle drewroengoogle added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Dec 4, 2023
@auto-submit
auto-submit Bot merged commit e1a2bb3 into flutter:master Dec 4, 2023
@christopherfujino

christopherfujino commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

nice, thanks @drewroengoogle

@godofredoc godofredoc added the revert Autorevert PR (with "Reason for revert:" comment) label Dec 5, 2023
@auto-submit auto-submit Bot mentioned this pull request Dec 5, 2023
Merged
8 tasks done
@auto-submit auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Dec 5, 2023
auto-submit Bot pushed a commit that referenced this pull request Dec 5, 2023
auto-submit[bot]
Revert "Update sync-labels to use boolean (#139516)"
e63c0bb 
This reverts commit e1a2bb3.
auto-submit Bot added a commit that referenced this pull request Dec 5, 2023
@auto-submit
Reverts "Update sync-labels to use boolean" (#139533)
5422af7 
Reverts #139516
Initiated by: godofredoc
This change reverts the following previous change:
Original Description:
actions/labeler#112 has been fixed, and now requires boolean to be used. 

Related infra issue that this fixes: #139511
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
5b8a5f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
5e062dd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
1b87c94
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
e025051
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
8a2b3de
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
8b4c441
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
003b0f3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
41b609a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
2838933
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
f03d450
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
a8eef5d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
8987148
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
0ec86ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
7efb441
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
8dc2d58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
ad19270
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
655b3da
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
00b37a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
86bff49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
9edda2a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
979e259
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
f03d027
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
5005c1d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
2d3e3e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
58c8aae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
52b6e4a
@drewroengoogle
drewroengoogle deleted the fix-sync-labels branch December 13, 2023 15:52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
e1a2bb3 Update sync-labels to use boolean (flutter/flutter#139516)
cc62161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino
1 more reviewer
@CaseyHillers CaseyHillers CaseyHillers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

labeler action failing presubmit on schema error after dependabot roll

4 participants

@drewroengoogle @CaseyHillers @christopherfujino @godofredoc