Push physical layers with paths instead of rects in RenderPhysicalModel. #13942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jan 5, 2018
Contributor
There was a problem hiding this comment.
rename this one to match the name you end up with on the engine side
This adjusts the framework to work with the engine change in flutter/engine#4519
amirh
added a commit
to amirh/flutter
that referenced
this pull request
Jan 11, 2018
…sicalModel. (flutter#13942)" That commit was reverted due to a performance problem which has now been fixed.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…sicalModel. (flutter#13942)" (flutter#13988) This reverts commit 57b4a52.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
flutter#14054) * Revive "Push physical layers with paths instead of rects in RenderPhysicalModel. (flutter#13942)" That commit was reverted due to a performance problem which has now been fixed. * Roll engine 05fe72d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the framework to work with the engine change in flutter/engine#4519