[WIP] Opt-in for smooth pointer scrolling #139392
Conversation
Piinks
added
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
a: text input
Piinks
added
a: desktop
|
Here's
|
|
Here's
|
|
Ah ok, thank you @loic-sharma this is very helpful. Trackpads on web should not be going through the animated pointer path. This is why we were unable to land this change previously because it caused sporadic results with trackpad on web. It looks like we need to better identify trackpads on web so that they do not go through this code path. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks again to @loic-sharma. I filed #139990 to follow up on the issue with identifying trackpads on web. I also updated #32120 to reflect the latest info on the bug, along with some work arounds and packages I found that achieve the desired effect. Until we resolve the web issue, I do not think we can land this as it causes erratic scrolling with trackpads on web, which is definitely not an improvement. 🙃 |
2 participants
WIP
Loosely based on the chromium smooth scroller for animating stepped mouse wheel scrolling.
Fixes #32120
The original PR (#115314) could not move forward until we could reliably distinguish trackpad input from mouse wheels on web. This was needed because trackpads already curve input deltas for smooth scrolling. If this curve is applied to already curved input, the user's scrolling input would go no where. A heuristic was added a while ago to identify trackpads on web, and it seems to be working well so let's see if we can get this in. :)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.