Skip to content

Migrate command usage values #139383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 26 commits into from
Dec 7, 2023
Merged

Migrate command usage values #139383

auto-submit merged 26 commits into from
Dec 7, 2023

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Dec 1, 2023 •
edited
Loading

Related to the tracker issue:

This PR migrates the Usage.command static method that sent custom dimensions for each command (if applicable). The screenshot below shows the different places where the usageValues getter is overwritten to return the necessary custom dimensions for that command.

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 1, 2023
@eliasyishak eliasyishak mentioned this pull request Dec 1, 2023
Closed
32 tasks
@eliasyishak
Copy link
Contributor Author

eliasyishak commented Dec 1, 2023

@christopherfujino here's the PR with the migration for the new events as well for reference

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Dec 5, 2023
@eliasyishak eliasyishak marked this pull request as ready for review December 5, 2023 13:36
@github-actions github-actions bot removed a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Dec 5, 2023
@eliasyishak
Copy link
Contributor Author

eliasyishak commented Dec 5, 2023

@christopherfujino this is now ready for you review

christopherfujino
christopherfujino reviewed Dec 5, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Dec 6, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Dec 6, 2023
View reviewed changes
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
f59a5f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
8b9e600
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
9988a8e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
1596aca
@eliasyishak eliasyishak deleted the ga4-migrate-command-usage-values branch December 7, 2023 19:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
16233a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
13d3345
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
96f4d47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
0df1e2c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
65dc783
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
55fc0ba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
96d0f4c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
4421d08
@eliasyishak eliasyishak mentioned this pull request Jan 5, 2024
Closed
@eliasyishak eliasyishak restored the ga4-migrate-command-usage-values branch January 5, 2024 13:55
eliasyishak added a commit to eliasyishak/flutter that referenced this pull request Jan 5, 2024
@eliasyishak
Migrate command usage values (flutter#139383)
4175eda 
Related to the tracker issue:
- flutter#128251

This PR migrates the `Usage.command` static method that sent custom dimensions for each command (if applicable). The screenshot below shows the different places where the `usageValues` getter is overwritten to return the necessary custom dimensions for that command.

<img width="285" alt="image" src="https://github.com/flutter/flutter/assets/42216813/e32d5100-0e17-4a4d-8f21-327a8c113a19">
auto-submit bot pushed a commit that referenced this pull request Jan 9, 2024
@eliasyishak
[CP] Migrate command usage values (#139383) (#141019)
019fc5d 
Fixes:
- #141017
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2b218fd Migrate command usage values (flutter/flutter#139383)
87aa34a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliasyishak @christopherfujino