Document difference between softWrap and maxLine #139363
Conversation
github-actions
bot
added
a: text input
|
The diagram changes are in flutter/assets-for-api-docs#228. I suppose that PR should be merged prior to this PR. |
paldepind
force-pushed
the
docs-softwrap-maxlines
branch
from
bad7d5f to
e5e5026
Compare
paldepind
force-pushed
the
docs-softwrap-maxlines
branch
from
e5e5026 to
25671f7
Compare
|
Thanks for the PR! Would you be willing to convert the examples you added to "live" examples that use Dartpad to show them running? It's a little more involved, since you'll have to add complete source files, and some simple tests, but it'll be much more useful for people to explore. There are lots of examples of these in the code, just search for If not, that's fine, we can just work with what you have. |
|
Thanks for the feedback @gspencergoog. I went back and forth between whether or not to include screenshots or a DartPad. I went with screenshots because a DartPad includes a lot of boilerplate in addition to the relevant code, because I felt the point was simple enough to capture with screenshots, and because it was easier. So I hope it's ok if we proceed with the current approach :) |
|
@gspencergoog Is it fine if we go ahead with the PR as is? :) |
|
Yes, we can move forward as-is. |
gspencergoog
added
the
autosubmit
|
Thanks for the merge! flutter/assets-for-api-docs#228 should be merged as well to ensure that the illustrations used in the documentation are available :) |
Oh, good point. Can you resolve the conflicts there and we can get it merged? |
flutter/flutter@cdc83e5...0eb7881 2023-12-19 [email protected] Shift some Linux-hosted tests on moto g4 to pixel 7 (flutter/flutter#140389) 2023-12-19 [email protected] Reland "Warn when Gradle plugins are applied using the legacy apply script method (flutter/flutter#140103) 2023-12-19 [email protected] Roll Packages from d7dee79 to be52ac8 (1 revision) (flutter/flutter#140386) 2023-12-19 [email protected] Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (flutter/flutter#140371) 2023-12-19 [email protected] Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (flutter/flutter#140367) 2023-12-19 [email protected] Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (flutter/flutter#140362) 2023-12-19 [email protected] Upgrade to version of leak tracker that does not depend on test_widgets. (flutter/flutter#140247) 2023-12-19 [email protected] Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) (flutter/flutter#140359) 2023-12-18 [email protected] Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) (flutter/flutter#140350) 2023-12-18 [email protected] SemanticsProperties: default `identifier` and `tooltip` to null (flutter/flutter#140283) 2023-12-18 [email protected] Document difference between softWrap and maxLine (flutter/flutter#139363) 2023-12-18 [email protected] Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) (flutter/flutter#140332) 2023-12-18 [email protected] Only run dart files as a test in the Android preview tools test shard (flutter/flutter#140099) 2023-12-18 [email protected] Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) (flutter/flutter#140328) 2023-12-18 [email protected] Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) (flutter/flutter#140324) 2023-12-18 [email protected] Roll Packages from 3f2e16b to d7dee79 (5 revisions) (flutter/flutter#140322) 2023-12-18 [email protected] Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) (flutter/flutter#140320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@gspencergoog I've fixed the conflicts 👍 |
Related to this PR: flutter/flutter#139363 Note that in addition to the new diagrams I also changed the "text_ellipsis" diagram. Most notably by adding a border which I think makes it more clear how the text is cut off. I also deleted the "text" diagram since I found it a bit superfluous and since it wasn't referred to in the text using the diagram in the documentation.
This PR fixes flutter#13631 through documentation as suggested in flutter#13631 (comment). Since the documentation additions rely on new screenshots this PR will be accompanied by a PR in the assets repository.
3 participants
This PR fixes #13631 through documentation as suggested in #13631 (comment).
Since the documentation additions rely on new screenshots this PR will be accompanied by a PR in the assets repository.