Skip to content

[Reland] Migration for the sendTiming events for package:unified_analytics #139299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 24 commits into from
Dec 4, 2023
Merged

[Reland] Migration for the sendTiming events for package:unified_analytics #139299

auto-submit merged 24 commits into from
Dec 4, 2023

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Nov 30, 2023

Relanding based on this comment:

Related to tracker issue:

image

The image above shows all of the instances where we have sendTiming. All of the call sites have been updated to use the new Event.timing event from package:unified_analytics.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@eliasyishak
Migrate the flutter command for --version
9ff40bb 
This needs to be done on its own because we return before the `_sendPostUsage` method can send the command ran
@eliasyishak
Merge remote-tracking branch 'upstream/master' into ga4-send-timing-m…
39a6484 
…igration
@eliasyishak
Update pubspec.yaml
71e8aa1
@eliasyishak
Migration for gradle.dart complete
e3d4180
@eliasyishak
Migration for packages.dart complete
2e6148a
@eliasyishak
Migration for mac.dart complete
a8dcbca
@eliasyishak
Migration for resident_web_runner.dart complete
77677b6
@eliasyishak
Migration for build_linux.dart complete
8911ef8
@eliasyishak
Migration for build_macos.dart complete
7f925d2
@eliasyishak
Migration for run_hot.dart complete
f8b6807
@eliasyishak
Migration for flutter_command.dart complete
4375384
@eliasyishak
Fix test due to additional events being present
f9da2bd
@eliasyishak
Fix test to use event look up
a8f523a 
Duration is 0 so it is easy to look that up
@eliasyishak
Merge branch 'master' into ga4-send-timing-migration
a91938d
@eliasyishak
Migration for compile.dart complete
2657978
@eliasyishak
Migration for build_windows.dart complete
c557e72
@eliasyishak
Adding missing test case
8220624
@eliasyishak
Fix analyze error
ed8d8c8
@eliasyishak
Empty commit to kick off g3fix
5c4b3f2
@eliasyishak
Swap out global getter
429c666
@eliasyishak
Nit fixes from code review
c439c44
@eliasyishak
Merge branch 'master' into ga4-send-timing-migration
efde6c1
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Nov 30, 2023
@eliasyishak
Copy link
Contributor Author

eliasyishak commented Nov 30, 2023

@CaseyHillers, i'll leave this here until your changes have been made, thanks for following up :)

@eliasyishak eliasyishak mentioned this pull request Nov 30, 2023
Closed
32 tasks
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Dec 1, 2023

@eliasyishak do you know how frequent unfiied_analytics gets updated in the Dart SDK? It seems like there hasn't been any updates there (at least in the version used by Google), which is why Google testing is failing.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
23db403 
…nified_analytics` (flutter/flutter#139299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
27a8362 
…nified_analytics` (flutter/flutter#139299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
cd2d24c 
…nified_analytics` (flutter/flutter#139299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
4ebed62 
…nified_analytics` (flutter/flutter#139299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
603914d 
…nified_analytics` (flutter/flutter#139299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
b3a1a8a 
…nified_analytics` (flutter/flutter#139299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
3d0c8d4 
…nified_analytics` (flutter/flutter#139299)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
6ca557b 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
40668a3 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
efadde5 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
1f8c986 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
b3240c7 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
fa3d2d3 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
200b397 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
ee7f6c6 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
5d616a4 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
a3abca0 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
e71b16a 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
22c9dd9 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
41401e3 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
2266723 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
b3a6ff0 
…nified_analytics` (flutter/flutter#139299)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2d60241 [Reland] Migration for the sendTiming events for `package:u…
08ddd4c 
…nified_analytics` (flutter/flutter#139299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliasyishak @CaseyHillers @christopherfujino