Skip to content

Conversation

@zanderso
Copy link
Member

These tests are now expected to be reasonably stable, and increases in flakiness should be reported as part of the regular flaky test triage process.

@zanderso
Copy link
Member Author

zanderso commented Nov 30, 2023

I count ~30 of these devices in the lab, so hopefully this shouldn't cause any problems that can't be solved by shifting a few Pixel 7s from staging to prod. cc @yusuf-goog

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanderso zanderso merged commit 918e336 into flutter:master Nov 30, 2023
@zanderso zanderso deleted the android-impeller-prod branch November 30, 2023 14:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 30, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 30, 2023
flutter/flutter@5e5b529...918e336

2023-11-30 [email protected] Move Impeller tests on Pixel 7 Pro from staging to prod (flutter/flutter#139280)
2023-11-30 [email protected] Introduce multi-touch drag strategies for `DragGestureRecognizer` (flutter/flutter#136708)
2023-11-30 [email protected] Use the correct recipe on fuchsia_precache. (flutter/flutter#139279)
2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migration for the `sendTiming` events for `package:unified_analytics`" (flutter/flutter#139278)
2023-11-30 [email protected] Migrate fuchsia_precache to shard tests. (flutter/flutter#139202)
2023-11-29 [email protected] Fix chips `onDeleted` callback don't show the delete button when disabled (flutter/flutter#137685)
2023-11-29 [email protected] Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (flutter/flutter#139259)
2023-11-29 [email protected] Refactor to use Apple system fonts (flutter/flutter#137275)
2023-11-29 [email protected] Dynamic view sizing (flutter/flutter#138648)
2023-11-29 [email protected] Roll dependencies (flutter/flutter#139203)
2023-11-29 [email protected] add sourceTimeStamp to ScaleUpdateDetails (flutter/flutter#135936)
2023-11-29 [email protected] Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (flutter/flutter#139250)
2023-11-29 [email protected] Remove deprecated `PlatformMenuBar.body` (flutter/flutter#138509)
2023-11-29 [email protected] Migration for the `sendTiming` events for `package:unified_analytics` (flutter/flutter#138896)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
These tests are now expected to be reasonably stable, and increases in
flakiness should be reported as part of the regular flaky test triage
process.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants