Skip to content

Remove deprecated parameters from ElevatedButton.styleFrom(), OutlinedButton.styleFrom(), and TextButton.styleFrom() - #139267

Merged
QuncCccccc merged 3 commits into
flutter:masterfrom
QuncCccccc:remove_deprecated_api
Dec 6, 2023
Merged

Remove deprecated parameters from ElevatedButton.styleFrom(), OutlinedButton.styleFrom(), and TextButton.styleFrom()#139267
QuncCccccc merged 3 commits into
flutter:masterfrom
QuncCccccc:remove_deprecated_api

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Nov 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is to remove deprecated APIs from framework. They are:

  • primary from ElevatedButton.styleFrom
  • onPrimary from ElevatedButton.styleFrom
  • onSurface from ElevatedButton.styleFrom
  • primary from OutlinedButton.styleFrom
  • onSurface from OutlinedButton.styleFrom
  • primary from TextButton.styleFrom
  • onSurface from TextButton.styleFrom

These parameters are made obsolete in #105291.
Part of #139243

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Nov 29, 2023
@QuncCccccc QuncCccccc changed the title Remove deprecated parameters from ElevatedButton, OutlinedButton, and TextButton's styleFrom() Remove deprecated parameters from ElevatedButton.styleFrom(), OutlinedButton.styleFrom(), and TextButton.styleFrom() Nov 29, 2023
@QuncCccccc
QuncCccccc force-pushed the remove_deprecated_api branch from 4b68faf to e73b881 Compare December 4, 2023 18:32
@QuncCccccc

QuncCccccc commented Dec 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @Piinks! The error message from the failed Linux flutter_plugins test says the removed apis are used in Flutter Packages repo, but seems the deprecated api references have been removed and code is updated there(code link). Any idea how to update this test to use the latest version? Tried to rebase master but still got this error:(

This PR would be ready to review once this is fixed😃

Piinks
Piinks reviewed Dec 4, 2023
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, the error is coming not from file_selector, but file_selector_macos and file_selector_windows.

Here are where the code is not updated:

@QuncCccccc

QuncCccccc commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Ah I see, the error is coming not from file_selector, but file_selector_macos and file_selector_windows.

Here are where the code is not updated:

Oh my bad. Thanks for the help! Will create a PR over there:)

@QuncCccccc
QuncCccccc force-pushed the remove_deprecated_api branch from e73b881 to 54684ac Compare December 5, 2023 19:09
@github-actions github-actions Bot removed a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Dec 5, 2023
@QuncCccccc
QuncCccccc force-pushed the remove_deprecated_api branch from 54684ac to 033f035 Compare December 6, 2023 17:57
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Dec 6, 2023
@QuncCccccc
QuncCccccc marked this pull request as ready for review December 6, 2023 18:31
@QuncCccccc
QuncCccccc requested a review from Piinks December 6, 2023 18:31
Piinks
Piinks approved these changes Dec 6, 2023
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuncCccccc
QuncCccccc merged commit 2230c09 into flutter:master Dec 6, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
a2a2f78 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
5826569 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
7f887a9 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
7ae9118 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
4857b9a 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
b2b0361 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
643df22 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
cf2228c 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
8ab52af 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
b37095b 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
e697c59 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
6434277 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
29951cc 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
d763653 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
@HansMuller HansMuller mentioned this pull request Dec 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2230c09 Remove deprecated parameters from `ElevatedButton.styleFrom()…
faf4899 
…`, `OutlinedButton.styleFrom()`, and `TextButton.styleFrom()` (flutter/flutter#139267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @Piinks