Skip to content

Fix DatePicker Dialog content not visible on lower text scale #139236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Dec 6, 2023
Merged

Fix DatePicker Dialog content not visible on lower text scale #139236

auto-submit merged 1 commit into from
Dec 6, 2023

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Nov 29, 2023

fixes DatePicker dialog contents are hidden when using smaller text size

Description

  • Fixed DatePicker dialog contents are hidden when using smaller text size.
  • Add golden tests

Golden Test (Before)

TextScale - 0.88 TextScale - 1.0 TextScale - 2.0

Golden Test (After)

TextScale - 0.88 TextScale - 1.0 TextScale - 2.0

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 29, 2023
@TahaTesser TahaTesser force-pushed the fix_date_picker_dialog_content branch 2 times, most recently from 316757f to be3d379 Compare November 29, 2023 16:12
@TahaTesser TahaTesser marked this pull request as draft November 29, 2023 20:39
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 29, 2023

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@TahaTesser TahaTesser changed the title Fix DatePicker Dialog content not visible on lower text scale [WIP] Fix DatePicker Dialog content not visible on lower text scale Dec 1, 2023
@TahaTesser TahaTesser force-pushed the fix_date_picker_dialog_content branch from be3d379 to 04c24cf Compare December 5, 2023 11:14
@TahaTesser TahaTesser force-pushed the fix_date_picker_dialog_content branch from 04c24cf to 6dd7b1b Compare December 5, 2023 13:11
@TahaTesser TahaTesser changed the title [WIP] Fix DatePicker Dialog content not visible on lower text scale Fix DatePicker Dialog content not visible on lower text scale Dec 5, 2023
@TahaTesser TahaTesser marked this pull request as ready for review December 5, 2023 14:01
@TahaTesser
Copy link
Member Author

TahaTesser commented Dec 5, 2023

@MitchellGoodwin
This looks ready to review :)

@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 5, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #139236 at sha 6dd7b1b

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Dec 5, 2023
MitchellGoodwin
MitchellGoodwin approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit auto-submit bot merged commit 2f95a5a into flutter:master Dec 6, 2023
@TahaTesser TahaTesser deleted the fix_date_picker_dialog_content branch December 6, 2023 11:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
1574dae 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
a1008fb 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
11040fa 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
38af43d 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
3073461 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
0f76624 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
f303262 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
0785975 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
c3ba187 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
598719a 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
43e8668 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
4d38d1f 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
0aef34d 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
42671df 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
52670a7 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
d320160 
…le (flutter/flutter#139236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
299a121 
…le (flutter/flutter#139236)
@HansMuller HansMuller mentioned this pull request Dec 15, 2023
Closed
This was referenced Dec 18, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2f95a5a Fix DatePicker Dialog content not visible on lower text sca…
f4aaa5e 
…le (flutter/flutter#139236)
@MitchellGoodwin MitchellGoodwin mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DatePicker dialog contents are hidden when using smaller text size

2 participants

@TahaTesser @MitchellGoodwin