Add send_text_input_action case to deserialization_factory to allow sendTextInputAction usages through flutter_driver. #139197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
a: tests
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/139197, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
Contributor
Author
|
Hi. I'm not sure what could be the next step here? |
Contributor
|
sorry I missed this pr. This needs a secondary review. I will ask for someone on the team to take a look |
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/139197, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 22, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 22, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 22, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 23, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 23, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 29, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 30, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 30, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 31, 2023
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 2, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 2, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 2, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 2, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 2, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 3, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 4, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 4, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 4, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 5, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
… allow sendTextInputAction usages through flutter_driver. (flutter/flutter#139197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #131776.
Summary:
Previously in #106561, SendTextInputAction was added to Flutter Driver.
But it still cannot be used from flutter_driver tests. This PR intends to resolve that issue.
Issue:
An
DriverError: Unsupported command kind send_text_input_actionwould be thrown fromflutter_driver/lib/src/common/deserialization_factory.dartwhen a call todriver.sendTextInputAction(TextInputAction.done);was made despite the methodsendTextInputActionis available for use since #106561.Previous works has been done in #131776, I merely added tests.
Best regards.