Skip to content

Add background color to NavigationDrawerDestination - #139154

Merged
hannah-hyj merged 7 commits into
flutter:masterfrom
hannah-hyj:fix138105
Dec 7, 2023
Merged

Add background color to NavigationDrawerDestination#139154
hannah-hyj merged 7 commits into
flutter:masterfrom
hannah-hyj:fix138105

Conversation

@hannah-hyj

@hannah-hyj hannah-hyj commented Nov 28, 2023

Copy link
Copy Markdown
Member

fixes:#138105

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Nov 28, 2023
QuncCccccc
QuncCccccc reviewed Nov 28, 2023
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just left one question and some nits:)

Comment thread packages/flutter/lib/src/material/navigation_drawer.dart Resolved
Comment thread packages/flutter/test/material/navigation_drawer_test.dart Resolved
Comment thread packages/flutter/test/material/navigation_drawer_test.dart Resolved
@QuncCccccc

QuncCccccc commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Seems some Scuba failures are caught in Google testing.

@hannah-hyj

hannah-hyj commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

@QuncCccccc ping

QuncCccccc
QuncCccccc approved these changes Dec 7, 2023
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread packages/flutter/lib/src/material/navigation_drawer.dart Resolved
@hannah-hyj
hannah-hyj merged commit 81e390c into flutter:master Dec 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
00071b8 
…flutter#139154)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
eb3d8ba 
…flutter#139154)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
7b9a89c 
…flutter#139154)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
b87db48 
…flutter#139154)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
c21ba15 
…flutter#139154)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
fd5c6e6 
…flutter#139154)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
4d7c93d 
…flutter#139154)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
ae4a3fb 
…flutter#139154)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
81e390c Add background color to NavigationDrawerDestination (flutter/…
b2d68df 
…flutter#139154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannah-hyj @QuncCccccc