Skip to content

Update Tooltip tests for Material 3 - #139145

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
TahaTesser:update_tooltip_tests_m3
Dec 6, 2023
Merged

Update Tooltip tests for Material 3#139145
auto-submit[bot] merged 3 commits into
flutter:masterfrom
TahaTesser:update_tooltip_tests_m3

Conversation

@TahaTesser

@TahaTesser TahaTesser commented Nov 28, 2023

Copy link
Copy Markdown
Contributor

Updated unit tests for Tooltip to have M2 and M3 versions.

More info in #139076

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Nov 28, 2023
QuncCccccc
QuncCccccc reviewed Dec 4, 2023
View reviewed changes
Comment thread packages/flutter/test/material/tooltip_test.dart Resolved
Comment thread packages/flutter/test/material/tooltip_test.dart Resolved
Comment thread packages/flutter/test/material/tooltip_test.dart Resolved
@TahaTesser
TahaTesser requested a review from QuncCccccc December 5, 2023 14:01
QuncCccccc
QuncCccccc approved these changes Dec 5, 2023
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for keep doing this!

Comment thread packages/flutter/test/material/tooltip_test.dart Outdated

@QuncCccccc QuncCccccc Dec 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just a few more😄! Can we also do same changes as above:) ?

@TahaTesser TahaTesser Dec 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I forgot the theme class too.

Comment thread packages/flutter/test/material/tooltip_theme_test.dart Resolved
Comment thread packages/flutter/test/material/tooltip_theme_test.dart Resolved
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit
auto-submit Bot merged commit 3c8700c into flutter:master Dec 6, 2023
@TahaTesser
TahaTesser deleted the update_tooltip_tests_m3 branch December 6, 2023 13:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
8d21174
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
17c0f87
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
846251f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
8e58096
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
6d43c2f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
830b7af
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
da841da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
7acecac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
054d005
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
a89fbe8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
61a7eec
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
eb684d8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
73618f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
b8899be
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
3baa02c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
adc7895
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
214e243
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
0d59936
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
f6a7419
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
a8d5fec
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
3c8700c Update Tooltip tests for Material 3 (flutter/flutter#139145)
5624104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @QuncCccccc