Fix SliverGrid garbage collection issue #138915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
chunhtai
commented
Nov 22, 2023
Contributor
Author
There was a problem hiding this comment.
I copy over the code from RenderSliverFixedExtentBoxAdaptor
Member
There was a problem hiding this comment.
Could the logic live in a common place (e.g. the RenderSliverMultiBoxAdaptor base class) and be shared between the two instead of duplicating it?
Contributor
Author
There was a problem hiding this comment.
I don't want to expose these method because they are implementation detail. since this are only two instance, I prefer to keep it as is. We can revisit this if there are more use case for these logic
Member
|
Would you mind reverting some of the dartfmt changes that snuck into this PR? |
chunhtai
force-pushed
the
issues/138749
branch
from
99e9e63 to
98f87b2
Compare
Contributor
Author
done. |
goderbauer
approved these changes
Nov 22, 2023
Member
There was a problem hiding this comment.
Could the logic live in a common place (e.g. the RenderSliverMultiBoxAdaptor base class) and be shared between the two instead of duplicating it?
Co-authored-by: Michael Goderbauer <[email protected]>
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/138915, due to - The status or check suite Mac_build_test flutter_gallery__transition_perf_e2e_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 24, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 24, 2023
flutter/flutter@106667e...cf05f3c 2023-11-24 [email protected] Roll Flutter Engine from 7e640faa6adf to b1e0bf62fa35 (1 revision) (flutter/flutter#138979) 2023-11-24 [email protected] Roll Flutter Engine from d67ac2c561ca to 7e640faa6adf (2 revisions) (flutter/flutter#138969) 2023-11-24 [email protected] Roll Flutter Engine from 152790b5811b to d67ac2c561ca (1 revision) (flutter/flutter#138965) 2023-11-23 [email protected] Roll Flutter Engine from 4a344e050401 to 152790b5811b (1 revision) (flutter/flutter#138959) 2023-11-23 [email protected] Roll Flutter Engine from 6e71c3642abf to 4a344e050401 (1 revision) (flutter/flutter#138958) 2023-11-23 [email protected] Roll Flutter Engine from bec0dacaae41 to 6e71c3642abf (2 revisions) (flutter/flutter#138956) 2023-11-23 [email protected] [flutter_tools] Fix bad state future already completed in flutter logs (flutter/flutter#138517) 2023-11-23 [email protected] Fix SliverGrid garbage collection issue (flutter/flutter#138915) 2023-11-23 [email protected] Roll Flutter Engine from f331e0afaf2e to bec0dacaae41 (6 revisions) (flutter/flutter#138954) 2023-11-23 [email protected] Roll Packages from 2102327 to 6c5ad9e (1 revision) (flutter/flutter#138950) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
The code doesn't consider indices of children may not be continuous after rebuild. fixes flutter#138749
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code doesn't consider indices of children may not be continuous after rebuild.
fixes #138749
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.