Skip to content

Fix InputDecorationTheme copyWith fallback #138914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
talski wants to merge 2 commits into from
Closed

Fix InputDecorationTheme copyWith fallback #138914

talski wants to merge 2 commits into from

Conversation

@talski
Copy link

@talski talski commented Nov 22, 2023

The copyWith method from InputDecorationTheme was missing the fallback for iconColor;

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 22, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 22, 2023
@goderbauer
Copy link
Member

goderbauer commented Nov 28, 2023

Hallo! Thanks for the contribution. Can you please add a test for this so that we never accidentally regress this behavior in the future (see also the previous comment by the bot)? Thanks.

@goderbauer goderbauer mentioned this pull request Jan 29, 2024
Merged
@goderbauer
Copy link
Member

goderbauer commented Jan 29, 2024

Superseded by #142462.

@goderbauer goderbauer closed this Jan 29, 2024
auto-submit bot pushed a commit that referenced this pull request Jan 29, 2024
@goderbauer
Fix InputDecorationTheme copyWith fallback for iconColor (#142462)
c576f00 
Same as #138914, but with a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talski @goderbauer