[l10n] Update Material shareButtonLabel #138899
Conversation
github-actions
bot
added
framework
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
This may need to go through google internal translation pipeline. @HansMuller Do you know who is taking care of that now? or is there a doc on the process?
There was a problem hiding this comment.
The description is inaccourate. same for other buttonlabel in this file
There was a problem hiding this comment.
I upated the PR to remove the inaccurate 'on iOS' reference in those button label descriptions.
There was a problem hiding this comment.
Because this was a test I wrote some months ago (https://github.com/flutter/flutter/pull/130333/files) and where I made a cut and paste mistake (in test/material/translations_test.dart, we should rely on GlobalMaterialLocalizations, in that PR I updated both the cupertino test and the material test, and I wrongly copy/pasted this line.
There was a problem hiding this comment.
I may be misunderstanding this but according to this PR's description, This PR updates the Material label for the share option, currently it is "Share..." (the expected label on iOS), on Android it should be "Share". So it seems like this value shouldn't change?
There was a problem hiding this comment.
Sorry if this PR description is confusing, this change is the purpose of this PR: displaying 'Share' instead of 'Share...'.
'Share' is the native Android label, 'Share...' is the native iOS label.
This is similar to the select all label which is 'Select all' in Material localizations (same as native Android) and 'Select All' in Cupertino localizations (same as native iOS) :
Select all label for Material:
Select all label for Cupertino:
There was a problem hiding this comment.
Thanks for the explanation. It was the description of the shareButtonLabel message that threw me off; looks like you've already fixed that.
Docs are in the comments at the top of files listed below: If we end up adding messages to material_en.arb then this tool needs to be run to ensure that to-be-translated placeholders exist for all locales: If translations are updated in between releases then this tool needs to be run. Ordinarily, it's run by someone on the release team: |
bleroux
force-pushed
the
l10n_update_material_share_button_label
branch
from
fedd593 to
ad10bb6
Compare
I followed the step described at https://github.com/flutter/flutter/blob/master/packages/flutter_localizations/README.md#updating-an-existing-string |
|
@HansMuller Do you find out who can proceed with the approval of this change and push this through google internal translation pipeline? |
chunhtai
added
the
autosubmit
bleroux
force-pushed
the
l10n_update_material_share_button_label
branch
from
ad10bb6 to
240916c
Compare
flutter/flutter@918e336...d861ce4 2023-12-02 [email protected] Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423) 2023-12-02 [email protected] Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422) 2023-12-02 [email protected] Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421) 2023-12-02 [email protected] Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419) 2023-12-02 [email protected] Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418) 2023-12-02 [email protected] Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416) 2023-12-02 [email protected] Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414) 2023-12-02 [email protected] Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412) 2023-12-02 [email protected] Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410) 2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407) 2023-12-01 [email protected] Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397) 2023-12-01 [email protected] [l10n] Update Material shareButtonLabel (flutter/flutter#138899) 2023-12-01 [email protected] Retry on transient Skia failure. (flutter/flutter#139182) 2023-12-01 [email protected] Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394) 2023-12-01 [email protected] Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390) 2023-12-01 [email protected] Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389) 2023-12-01 [email protected] Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388) 2023-12-01 [email protected] Added vscode-insiders path installed via snap (flutter/flutter#137117) 2023-12-01 [email protected] Typo fix in dartdoc in tool test (flutter/flutter#139386) 2023-12-01 [email protected] Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348) 2023-12-01 [email protected] Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346) 2023-12-01 [email protected] Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345) 2023-12-01 [email protected] Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342) 2023-12-01 [email protected] Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264) 2023-11-30 [email protected] Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674) 2023-11-30 [email protected] Migrate docs_test to shard. (flutter/flutter#139282) 2023-11-30 [email protected] Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258) 2023-11-30 [email protected] Refactor prepare_package.dart (flutter/flutter#139277) 2023-11-30 [email protected] Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
## Description This PR updates the Material label for the share option, currently it is "**Share...**" (the expected label on iOS), on Android it should be "**Share**". Native Android TextField screenshot:  ## Related Issue Step 2 for flutter#138728 ## Tests Adds 1 test.
3 participants
Description
This PR updates the Material label for the share option, currently it is "Share..." (the expected label on iOS), on Android it should be "Share".
Native Android TextField screenshot:
Related Issue
Step 2 for #138728
Tests
Adds 1 test.