Fix turbulence seed for all tests with ink sparkles #138757

Piinks · 2023-11-20T21:57:36Z

Fixes #138753

This makes sure that InkSparkles are always fixed for testing rather than random.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks · 2023-11-20T21:58:54Z

packages/flutter/lib/src/material/ink_sparkle.dart

If the seed is set, it is not random anyways so I let it be. I don't want to break any existing tests or customers.

Piinks · 2023-11-20T21:59:39Z

packages/flutter/test/material/ink_sparkle_test.dart

I figured this should be the best validator, since these goldens will fail otherwise. Easy test!

Oh I think this is the wrong one. 😆

flutter-dashboard · 2023-11-20T22:28:13Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #138757 at sha be22293e7bf0b843e5aee48c5914f552a4a59d10

Piinks · 2023-11-20T22:31:08Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

Intriguing! 😆

bleroux

      ___       ___                         ___              
     /  /\     /  /\          ___          /  /\             
    /  /:/    /  /::\        /__/\        /  /::|            
   /  /:/    /  /:/\:\       \  \:\      /  /:|:|            
  /  /:/    /  /:/  \:\       \__\:\    /  /:/|:|__          
 /__/:/    /__/:/_\_ \:\      /  /::\  /__/:/_|::::\         
 \  \:\    \  \:\__/\_\/     /  /:/\:\ \__\/  /~~/:/         
  \  \:\    \  \:\ \:\      /  /:/__\/       /  /:/          
   \  \:\    \  \:\/:/     /__/:/           /  /:/           
    \  \:\    \  \::/      \__\/           /__/:/            
     \__\/     \__\/                       \__\/

This is a very smart way to tackle those flakes 👍

packages/flutter/lib/src/material/ink_sparkle.dart

auto-submit · 2023-11-28T14:30:11Z

auto label is removed for flutter/flutter/138757, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…flutter#138757)

Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) flutter/flutter@6bf3ccd...5e5b529 2023-11-29 [email protected] Roll Flutter Engine from 60b963930202 to 222beb28a8eb (2 revisions) (flutter/flutter#139242) 2023-11-29 [email protected] Roll Flutter Engine from eebbe7e15c7d to 60b963930202 (2 revisions) (flutter/flutter#139237) 2023-11-29 [email protected] Roll Packages from 3c05466 to e4aaba8 (5 revisions) (flutter/flutter#139232) 2023-11-29 [email protected] Update VelocityTracker (4) (flutter/flutter#139166) 2023-11-29 [email protected] Analyze against using Stopwatches in the framework (flutter/flutter#138507) 2023-11-29 [email protected] Roll Flutter Engine from ecc9c7b6be7d to eebbe7e15c7d (1 revision) (flutter/flutter#139225) 2023-11-29 [email protected] Roll Flutter Engine from 28aae2d29822 to ecc9c7b6be7d (1 revision) (flutter/flutter#139210) 2023-11-29 [email protected] Improve documentation of CardTheme.shape (flutter/flutter#139096) 2023-11-29 [email protected] Simplify devicelab logic and fix tests (flutter/flutter#139122) 2023-11-29 [email protected] implemented leadingWidth and automaticallyImplyLeading options (flutter/flutter#136165) 2023-11-29 [email protected] TextField and TextFormField can use a MaterialStatesController (flutter/flutter#133977) 2023-11-29 [email protected] Provide parameter to Icon and IconThemeData for they to consider the context's text scaler (flutter/flutter#135708) 2023-11-29 [email protected] Roll Flutter Engine from be4d7c8b760c to 28aae2d29822 (1 revision) (flutter/flutter#139204) 2023-11-29 [email protected] Update `ButtonStyleButton.scaledPadding` documentation. Migrate callers in flutter/flutter (flutter/flutter#139014) 2023-11-29 [email protected] Roll Flutter Engine from de99c71c598f to be4d7c8b760c (1 revision) (flutter/flutter#139199) 2023-11-29 [email protected] Roll Flutter Engine from 9a840e8dba40 to de99c71c598f (2 revisions) (flutter/flutter#139195) 2023-11-29 [email protected] Roll Flutter Engine from fbb2b1e880fa to 9a840e8dba40 (1 revision) (flutter/flutter#139192) 2023-11-29 [email protected] Roll Flutter Engine from 4beaa1195b74 to fbb2b1e880fa (1 revision) (flutter/flutter#139191) 2023-11-29 [email protected] Roll Flutter Engine from 570fec4fa92c to 4beaa1195b74 (3 revisions) (flutter/flutter#139190) 2023-11-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add platform view wide gamut test" (flutter/flutter#139189) 2023-11-28 [email protected] Move analysis test to shard tests. (flutter/flutter#139161) 2023-11-28 [email protected] Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`, `stepper.0`, `radio.0`, `filled_button.0`, `outlined_button.0` & `card.0` (flutter/flutter#138987) 2023-11-28 [email protected] Implement `switch` expressions in `dev/` (flutter/flutter#139048) 2023-11-28 [email protected] Roll Flutter Engine from 01fcec7214db to 570fec4fa92c (2 revisions) (flutter/flutter#139178) 2023-11-28 [email protected] Fix comment (flutter/flutter#138973) 2023-11-28 [email protected] Added some documentation for OverlayPortal (flutter/flutter#138934) 2023-11-28 [email protected] feature(table-widget): Added intrinsicHeight to TableCellVerticalAlignment enum. (flutter/flutter#130264) 2023-11-28 [email protected] Roll Flutter Engine from 97ede154dcd8 to 01fcec7214db (1 revision) (flutter/flutter#139172) 2023-11-28 [email protected] Ensure Icon vertically centers its icon glyph. (flutter/flutter#138937) 2023-11-28 [email protected] Roll Flutter Engine from fd3a33f8b239 to 97ede154dcd8 (2 revisions) (flutter/flutter#139168) 2023-11-28 [email protected] Roll Flutter Engine from d375d5b95d59 to fd3a33f8b239 (2 revisions) (flutter/flutter#139163) 2023-11-28 [email protected] Roll Flutter Engine from e4b18fa3661e to d375d5b95d59 (2 revisions) (flutter/flutter#139157) 2023-11-28 [email protected] Added keyboardType & textInputAction props to SearchBar, SearchAnchor & SearchAnchor.bar (flutter/flutter#138553) 2023-11-28 [email protected] Fix header formatting typo in PopupMenuButton docs (flutter/flutter#139084) 2023-11-28 [email protected] Fix turbulence seed for all tests with ink sparkles (flutter/flutter#138757) 2023-11-28 [email protected] Renable macOS 13 tests (flutter/flutter#139083) 2023-11-28 [email protected] Roll Flutter Engine from 8715e9b9119d to e4b18fa3661e (1 revision) (flutter/flutter#139142) 2023-11-28 [email protected] Roll Packages from e774e88 to 3c05466 (2 revisions) (flutter/flutter#139140) 2023-11-28 [email protected] Roll Flutter Engine from 6ad827e9a71b to 8715e9b9119d (1 revision) (flutter/flutter#139136) 2023-11-28 [email protected] Roll Flutter Engine from c18d3df967dc to 6ad827e9a71b (1 revision) (flutter/flutter#139135) 2023-11-28 [email protected] Roll Flutter Engine from 1caa7478db0d to c18d3df967dc (1 revision) (flutter/flutter#139133) 2023-11-28 [email protected] Roll Flutter Engine from 4f217e1f9afe to 1caa7478db0d (1 revision) (flutter/flutter#139129) 2023-11-28 [email protected] Fix textScalerOf and maybeTextScalerOf documentations (flutter/flutter#139123) 2023-11-28 [email protected] Roll Flutter Engine from c25cc65720de to 4f217e1f9afe (1 revision) (flutter/flutter#139126) 2023-11-28 [email protected] Roll Flutter Engine from 3381d3ff0df7 to c25cc65720de (1 revision) (flutter/flutter#139121) 2023-11-28 [email protected] Roll Flutter Engine from 96137d05fabc to 3381d3ff0df7 (4 revisions) (flutter/flutter#139119) ...

This PR removes the call to `InkSparkle.constantTurbulenceSeedSplashFactory` which was introduced in #137998. This is now obsolete since #138757 was merged and InkSparkle randomness is no more active in tests.

Fixes flutter#138753 This makes sure that InkSparkles are always fixed for testing rather than random.

@Piinks

…plash ink (#141777) This updates the previous attempt #135855 and removes the complications when testing M3 ink sparkle effect. Thanks to this [PR](#138757) by @Piinks fixes [ExpansionTile InkSplash doesn't respect Shape's borderRadius](#125779) fixes [`ExpansionTile.backgroundColor` & `ExpansionTile.collapsedBackgroundColor` removes splash effect](#107113) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return const MaterialApp( debugShowCheckedModeBanner: false, home: Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @OverRide Widget build(BuildContext context) { return const Scaffold( body: Center( child: Padding( padding: EdgeInsets.symmetric(horizontal: 24.0), child: ExpansionTile( collapsedBackgroundColor: Color(0x25ff0000), backgroundColor: Color(0x250000ff), collapsedShape: RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(30.0)), side: BorderSide(color: Colors.black, width: 2.0), ), shape: RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(30.0)), side: BorderSide(color: Colors.black, width: 2.0), ), clipBehavior: Clip.hardEdge, title: Text('Expansion Tile'), children: <Widget>[ FlutterLogo(size: 50), FlutterLogo(size: 50), FlutterLogo(size: 50), FlutterLogo(size: 50), ], ), )), ); } } ``` </details> ### Before <img width="789" alt="Screenshot 2024-01-18 at 18 16 15" src="https://github.com/flutter/flutter/assets/48603081/8c6a6f1e-6986-4acf-8dec-e223a682c0d7"> <img width="789" alt="Screenshot 2024-01-18 at 18 16 44" src="https://github.com/flutter/flutter/assets/48603081/f55f6a26-2128-48a1-b24d-3c14e4f6ecdc"> ### After <img width="789" alt="Screenshot 2024-01-18 at 18 20 27" src="https://github.com/flutter/flutter/assets/48603081/7ec8b888-7319-460d-8488-9cd44c9246a6"> <img width="789" alt="Screenshot 2024-01-18 at 18 20 53" src="https://github.com/flutter/flutter/assets/48603081/80d66d5b-7eb2-4f47-ab4d-d7f469a731fa">

…flutter#138757)

Piinks added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: flake Tests that sometimes, but not always, incorrectly pass labels Nov 20, 2023

Piinks commented Nov 20, 2023

View reviewed changes

Piinks requested review from TahaTesser and bleroux November 20, 2023 21:59

flutter-dashboard bot added the will affect goldens Changes to golden files label Nov 20, 2023

bleroux approved these changes Nov 21, 2023

View reviewed changes

bleroux mentioned this pull request Nov 21, 2023

Reland update bottom navigation bar test for m3 #137998

Merged

Piinks commented Nov 21, 2023

View reviewed changes

packages/flutter/lib/src/material/ink_sparkle.dart Outdated Show resolved Hide resolved

Piinks commented Nov 21, 2023

View reviewed changes

packages/flutter/lib/src/material/ink_sparkle.dart Outdated Show resolved Hide resolved

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 21, 2023

Piinks added 4 commits November 27, 2023 11:32

Fix tubulence seed for all tests with ink sparkles

bd1ffd7

Swap

f70ede0

Update packages/flutter/lib/src/material/ink_sparkle.dart

f2c5d83

Update packages/flutter/lib/src/material/ink_sparkle.dart

3c5369a

Piinks force-pushed the inkFixed branch from fcc2c79 to 3c5369a Compare November 27, 2023 17:32

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 28, 2023

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 28, 2023

auto-submit bot merged commit 92ad558 into flutter:master Nov 28, 2023

engine-flutter-autoroll mentioned this pull request Nov 28, 2023

Roll Flutter from 6bf3ccd47d5d to 92ad558e257d (24 revisions) flutter/packages#5509

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

4626690

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 28, 2023

Roll Flutter from 6bf3ccd47d5d to 89edac404184 (25 revisions) flutter/packages#5510

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

a2a65cd

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 28, 2023

Roll Flutter from 6bf3ccd47d5d to 18b239fbde3a (26 revisions) flutter/packages#5511

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

593fcca

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 29, 2023

Manual roll Flutter from 6bf3ccd47d5d to 20eb3ea1318f (39 revisions) flutter/packages#5513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

8f2d1d8

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 29, 2023

Roll Flutter from 6bf3ccd47d5d to 133711ba9ad8 (54 revisions) flutter/packages#5515

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

7a1877f

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 29, 2023

Roll Flutter from 6bf3ccd47d5d to 8ba459ce9fef (55 revisions) flutter/packages#5516

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

809ce54

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 29, 2023

Roll Flutter from 6bf3ccd47d5d to 85d311d6320c (56 revisions) flutter/packages#5517

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

22f3b45

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 29, 2023

Roll Flutter from 6bf3ccd47d5d to f53e68a11a51 (57 revisions) flutter/packages#5518

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

29fecf4

…flutter#138757)

engine-flutter-autoroll mentioned this pull request Nov 29, 2023

Roll Flutter from 6bf3ccd47d5d to 5e5b5292f739 (58 revisions) flutter/packages#5519

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

5d48d8b

…flutter#138757)

bleroux mentioned this pull request Dec 4, 2023

Remove InkSparkle.constantTurbulenceSeedSplashFactory usage #139481

Merged

caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023

Fix turbulence seed for all tests with ink sparkles (flutter#138757)

7e69771

Fixes flutter#138753 This makes sure that InkSparkles are always fixed for testing rather than random.

TahaTesser mentioned this pull request Jan 18, 2024

Fix shape and collapsedShape isn't applied to ExpansionTile's splash ink #141777

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

92ad558 Fix turbulence seed for all tests with ink sparkles (flutter/…

e9a30c9

…flutter#138757)

Piinks mentioned this pull request Sep 26, 2025

Reimplemented StretchingOverscrollIndicator with Simulation ported from Android 12. #173849

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix turbulence seed for all tests with ink sparkles #138757

Fix turbulence seed for all tests with ink sparkles #138757

Uh oh!

Piinks commented Nov 20, 2023

Uh oh!

Piinks Nov 20, 2023

Uh oh!

Piinks Nov 20, 2023

Uh oh!

Piinks Nov 20, 2023

Uh oh!

flutter-dashboard bot commented Nov 20, 2023

Uh oh!

Piinks commented Nov 20, 2023

Uh oh!

bleroux left a comment

Uh oh!

Uh oh!

Uh oh!

auto-submit bot commented Nov 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix turbulence seed for all tests with ink sparkles #138757

Fix turbulence seed for all tests with ink sparkles #138757

Uh oh!

Conversation

Piinks commented Nov 20, 2023

Pre-launch Checklist

Uh oh!

Piinks Nov 20, 2023

Choose a reason for hiding this comment

Uh oh!

Piinks Nov 20, 2023

Choose a reason for hiding this comment

Uh oh!

Piinks Nov 20, 2023

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Nov 20, 2023

Uh oh!

Piinks commented Nov 20, 2023

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

auto-submit bot commented Nov 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants